Consider Allowing Usage of Custom Types for Nested Attributes #533
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #532
Following changes are included in this PR:
FrameworkValue
interface.fwschema/attribute.go
totypes/attribute.go
to avoid import cycles.fwschema/nested_attributes.go
totypes/nested_attributes.go
to exposeNestedAttributes
interface for use in custom nested attribute types.I am not convinced that
attribute.go
andnested_attributes.go
should be in thetypes
pkg.