Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tfprotov5+tfprotov6: Initial MoveResourceState support #364

Merged
merged 4 commits into from
Jan 17, 2024

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jan 12, 2024

Closes #362
Reference: #363

The next version of the plugin protocol (5.5/6.5) includes support for moving resource state. This change introduces the initial implementation of that support including:

  • Updated Protocol Buffers definitions
  • Re-generated Protocol Buffers Go code
  • Initial implementations of tfprotov5 and tfprotov6 package abstractions and wiring between those abstractions and the Protocol Buffers generated Go code
  • Initial implementations of tfprotov5/tf5server and tfprotov6/tf6server for the new MoveResourceState RPC

This temporarily will not require ProviderServer implementations to include MoveResourceState implementation, however that change will occur in a subsequent release.

Reference: #362
Reference: #363

The next version of the plugin protocol (5.5/6.5) includes support for moving resource state. This change introduces the initial implementation of that support including:

- Updated Protocol Buffers definitions
- Re-generated Protocol Buffers Go code
- Initial implementations of `tfprotov5` and `tfprotov6` package abstractions and wiring between those abstractions and the Protocol Buffers generated Go code
- Initial implementations of `tfprotov5/tf5server` and `tfprotov6/tf6server` for the new `MoveResourceState` RPC

This temporarily will not require `ProviderServer` implementations to include `MoveResourceState` implementation, however that change will occur in a subsequent release.
@bflad bflad added the enhancement New feature or request label Jan 12, 2024
@bflad bflad added this to the v0.21.0 milestone Jan 12, 2024
@bflad bflad requested a review from a team as a code owner January 12, 2024 15:10
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bflad bflad merged commit bd50706 into main Jan 17, 2024
61 checks passed
@bflad bflad deleted the bflad/MoveResourceState branch January 17, 2024 14:57
bflad added a commit to hashicorp/terraform-plugin-mux that referenced this pull request Jan 26, 2024
Reference: hashicorp/terraform-plugin-go#364

The next versions of the plugin protocol (5.5/6.5) include support for the MoveResourceState RPC and server capability. This change includes initial implementation of the new RPC in all server implementations.
bflad added a commit to hashicorp/terraform-plugin-mux that referenced this pull request Jan 29, 2024
Reference: hashicorp/terraform-plugin-go#364

The next versions of the plugin protocol (5.5/6.5) include support for the MoveResourceState RPC and server capability. This change includes initial implementation of the new RPC in all server implementations.
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tfprotov5+tfprotov6: Implement MoveResourceState RPC
3 participants