Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/provider: Prevent skip issues with special region testing involving multiple tests #17421

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Feb 3, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #16840 (review)

Output from acceptance testing in AWS Commercial:

--- FAIL: TestAccAWSAPIGatewayDomainName_CertificateArn (965.31s) # https://github.com/hashicorp/terraform-provider-aws/issues/17420
--- PASS: TestAccAWSAPIGatewayDomainName_disappears (152.03s)
--- PASS: TestAccAWSAPIGatewayDomainName_RegionalCertificateArn (110.11s)
--- PASS: TestAccAWSAPIGatewayDomainName_SecurityPolicy (115.66s)
--- PASS: TestAccAWSAPIGatewayDomainName_Tags (126.40s)
--- SKIP: TestAccAWSAPIGatewayDomainName_CertificateName (0.00s)
--- SKIP: TestAccAWSAPIGatewayDomainName_RegionalCertificateName (0.00s)

--- PASS: TestAccAWSCognitoUserPoolDomain_basic (29.57s)
--- PASS: TestAccAWSCognitoUserPoolDomain_custom (770.94s)
--- PASS: TestAccAWSCognitoUserPoolDomain_disappears (27.19s)

--- PASS: TestAccAWSLightsailDomain_basic (23.82s)
--- PASS: TestAccAWSLightsailDomain_disappears (20.95s)

--- PASS: TestAccAWSRoute53QueryLog_basic (51.64s)

--- PASS: TestAccAWSWafWebAcl_basic (20.01s)
--- PASS: TestAccAWSWafWebAcl_changeNameForceNew (45.63s)
--- PASS: TestAccAWSWafWebAcl_DefaultAction (36.54s)
--- PASS: TestAccAWSWafWebAcl_disappears (21.46s)
--- PASS: TestAccAWSWafWebAcl_LoggingConfiguration (110.88s)
--- PASS: TestAccAWSWafWebAcl_Rules (60.21s)
--- PASS: TestAccAWSWafWebAcl_Tags (50.74s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSAPIGatewayDomainName_disappears (28.66s)
--- PASS: TestAccAWSAPIGatewayDomainName_RegionalCertificateArn (79.60s)
--- PASS: TestAccAWSAPIGatewayDomainName_SecurityPolicy (110.56s)
--- PASS: TestAccAWSAPIGatewayDomainName_Tags (139.40s)
--- SKIP: TestAccAWSAPIGatewayDomainName_CertificateArn (0.00s)
--- SKIP: TestAccAWSAPIGatewayDomainName_CertificateName (0.00s)
--- SKIP: TestAccAWSAPIGatewayDomainName_RegionalCertificateName (0.00s)

--- PASS: TestAccAWSCognitoUserPoolDomain_basic (29.53s)
--- PASS: TestAccAWSCognitoUserPoolDomain_disappears (25.98s)
--- SKIP: TestAccAWSCognitoUserPoolDomain_custom (0.00s)

--- SKIP: TestAccAWSLightsailDomain_basic (3.48s)
--- SKIP: TestAccAWSLightsailDomain_disappears (3.48s)

--- SKIP: TestAccAWSRoute53QueryLog_basic (3.48s)

--- SKIP: TestAccAWSWafWebAcl_basic (27.40s)
--- SKIP: TestAccAWSWafWebAcl_changeNameForceNew (27.75s)
--- SKIP: TestAccAWSWafWebAcl_DefaultAction (21.04s)
--- SKIP: TestAccAWSWafWebAcl_disappears (25.19s)
--- SKIP: TestAccAWSWafWebAcl_LoggingConfiguration (28.85s)
--- SKIP: TestAccAWSWafWebAcl_Rules (30.87s)
--- SKIP: TestAccAWSWafWebAcl_Tags (29.67s)

…ving multiple tests

Reference: #16840 (review)

Output from acceptance testing in AWS Commercial:

```
--- FAIL: TestAccAWSAPIGatewayDomainName_CertificateArn (965.31s) # #17420
--- PASS: TestAccAWSAPIGatewayDomainName_disappears (152.03s)
--- PASS: TestAccAWSAPIGatewayDomainName_RegionalCertificateArn (110.11s)
--- PASS: TestAccAWSAPIGatewayDomainName_SecurityPolicy (115.66s)
--- PASS: TestAccAWSAPIGatewayDomainName_Tags (126.40s)
--- SKIP: TestAccAWSAPIGatewayDomainName_CertificateName (0.00s)
--- SKIP: TestAccAWSAPIGatewayDomainName_RegionalCertificateName (0.00s)

--- PASS: TestAccAWSCognitoUserPoolDomain_basic (29.57s)
--- PASS: TestAccAWSCognitoUserPoolDomain_custom (770.94s)
--- PASS: TestAccAWSCognitoUserPoolDomain_disappears (27.19s)

--- PASS: TestAccAWSLightsailDomain_basic (23.82s)
--- PASS: TestAccAWSLightsailDomain_disappears (20.95s)

--- PASS: TestAccAWSRoute53QueryLog_basic (51.64s)

--- PASS: TestAccAWSWafWebAcl_basic (20.01s)
--- PASS: TestAccAWSWafWebAcl_changeNameForceNew (45.63s)
--- PASS: TestAccAWSWafWebAcl_DefaultAction (36.54s)
--- PASS: TestAccAWSWafWebAcl_disappears (21.46s)
--- PASS: TestAccAWSWafWebAcl_LoggingConfiguration (110.88s)
--- PASS: TestAccAWSWafWebAcl_Rules (60.21s)
--- PASS: TestAccAWSWafWebAcl_Tags (50.74s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAWSAPIGatewayDomainName_disappears (28.66s)
--- PASS: TestAccAWSAPIGatewayDomainName_RegionalCertificateArn (79.60s)
--- PASS: TestAccAWSAPIGatewayDomainName_SecurityPolicy (110.56s)
--- PASS: TestAccAWSAPIGatewayDomainName_Tags (139.40s)
--- SKIP: TestAccAWSAPIGatewayDomainName_CertificateArn (0.00s)
--- SKIP: TestAccAWSAPIGatewayDomainName_CertificateName (0.00s)
--- SKIP: TestAccAWSAPIGatewayDomainName_RegionalCertificateName (0.00s)

--- PASS: TestAccAWSCognitoUserPoolDomain_basic (29.53s)
--- PASS: TestAccAWSCognitoUserPoolDomain_disappears (25.98s)
--- SKIP: TestAccAWSCognitoUserPoolDomain_custom (0.00s)

--- SKIP: TestAccAWSLightsailDomain_basic (3.48s)
--- SKIP: TestAccAWSLightsailDomain_disappears (3.48s)

--- SKIP: TestAccAWSRoute53QueryLog_basic (3.48s)

--- SKIP: TestAccAWSWafWebAcl_basic (27.40s)
--- SKIP: TestAccAWSWafWebAcl_changeNameForceNew (27.75s)
--- SKIP: TestAccAWSWafWebAcl_DefaultAction (21.04s)
--- SKIP: TestAccAWSWafWebAcl_disappears (25.19s)
--- SKIP: TestAccAWSWafWebAcl_LoggingConfiguration (28.85s)
--- SKIP: TestAccAWSWafWebAcl_Rules (30.87s)
--- SKIP: TestAccAWSWafWebAcl_Tags (29.67s)
```
@bflad bflad requested a review from a team as a code owner February 3, 2021 01:24
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/apigateway Issues and PRs that pertain to the apigateway service. service/cognito service/lightsail Issues and PRs that pertain to the lightsail service. service/route53 Issues and PRs that pertain to the route53 service. service/waf Issues and PRs that pertain to the waf service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 3, 2021
@gdavison gdavison self-assigned this Feb 17, 2021
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

Waiting on acceptance tests

@bflad
Copy link
Contributor Author

bflad commented Feb 18, 2021

Test results from TeamCity run kicked off above:

--- SKIP: TestAccAWSAPIGatewayDomainName_MutualTlsAuthentication (0.00s)
--- SKIP: TestAccAWSAPIGatewayDomainName_RegionalCertificateName (0.00s)
--- SKIP: TestAccAWSAPIGatewayDomainName_CertificateName (0.00s)
--- SKIP: TestAccAWSCognitoUserPoolDomain_custom (0.00s)
--- SKIP: TestAccAWSAPIGatewayDomainName_CertificateArn (0.00s)
--- PASS: TestAccAWSCognitoUserPoolDomain_disappears (33.20s)
--- PASS: TestAccAWSCognitoUserPoolDomain_basic (33.99s)
--- PASS: TestAccAWSAPIGatewayDomainName_disappears (34.89s)
--- PASS: TestAccAWSLightsailDomain_disappears (38.38s)
--- PASS: TestAccAWSLightsailDomain_basic (38.72s)
--- PASS: TestAccAWSWafWebAcl_basic (40.26s)
--- PASS: TestAccAWSWafWebAcl_disappears (46.56s)
--- PASS: TestAccAWSWafWebAcl_DefaultAction (56.26s)
--- PASS: TestAccAWSWafWebAcl_changeNameForceNew (62.27s)
--- PASS: TestAccAWSRoute53QueryLog_basic (69.44s)
--- PASS: TestAccAWSWafWebAcl_Tags (70.09s)
--- FAIL: TestAccAWSWafWebAcl_Rules (79.86s)
--- PASS: TestAccAWSAPIGatewayDomainName_RegionalCertificateArn (84.55s)
--- PASS: TestAccAWSWafWebAcl_LoggingConfiguration (164.81s)
--- PASS: TestAccAWSAPIGatewayDomainName_SecurityPolicy (192.60s)
--- PASS: TestAccAWSAPIGatewayDomainName_Tags (235.58s)

One failure is present on main branch.

@bflad bflad merged commit c015ad6 into main Feb 18, 2021
@bflad bflad deleted the t-provider-sync-once-skip-once branch February 18, 2021 20:26
@github-actions github-actions bot added this to the v3.29.0 milestone Feb 18, 2021
@ghost
Copy link

ghost commented Feb 19, 2021

This has been released in version 3.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 21, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/apigateway Issues and PRs that pertain to the apigateway service. service/lightsail Issues and PRs that pertain to the lightsail service. service/route53 Issues and PRs that pertain to the route53 service. service/waf Issues and PRs that pertain to the waf service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants