Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/s3_bucket_replication_configuration: make event_threshold optional in destination metrics config block #21901

Merged
merged 2 commits into from
Dec 1, 2021
Merged

r/s3_bucket_replication_configuration: make event_threshold optional in destination metrics config block #21901

merged 2 commits into from
Dec 1, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Nov 25, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21895

Output from acceptance testing:

--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics (269.32s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter (269.11s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Nov 25, 2021
@anGie44 anGie44 force-pushed the b-s3-bucket-replication-config-event-threshold branch from 38f8113 to 429b2a3 Compare November 25, 2021 02:03
@anGie44 anGie44 changed the title r/s3_bucket_replication_configuration: make event_threshold optional in destination config block r/s3_bucket_replication_configuration: make event_threshold optional in destination metrics config block Nov 25, 2021
anGie44
anGie44 commented Nov 25, 2021
View reviewed changes
internal/service/s3/bucket.go
"status": aws.StringValue(v.Destination.Metrics.Status),
"status": aws.StringValue(v.Destination.Metrics.Status),
}
if v.Destination.Metrics.EventThreshold != nil {
Copy link
Contributor Author

@anGie44 anGie44 Nov 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prevents panic when event_threshold isn't configured in new acctest

@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Nov 25, 2021
@robmp
Copy link

robmp commented Dec 1, 2021

I've done manual tests with provider built from this branch and can confirm it fixes #21895

ewbankkit
ewbankkit reviewed Dec 1, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS="-run=TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics\|TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter" PKG_NAME="./internal/service/s3"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ././internal/service/s3/... -v -count 1 -parallel 20 -run=TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics\|TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter -timeout 180m
=== RUN   TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter
=== PAUSE TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter
=== RUN   TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics
=== PAUSE TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics
=== CONT  TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter
=== CONT  TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter (272.63s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics (273.64s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	276.922s

@anGie44 anGie44 added this to the v3.68.0 milestone Dec 1, 2021
@anGie44 anGie44 merged commit 9addd5c into main Dec 1, 2021
@anGie44 anGie44 deleted the b-s3-bucket-replication-config-event-threshold branch December 1, 2021 18:08
github-actions bot pushed a commit that referenced this pull request Dec 1, 2021
Update CHANGELOG.md for #21901
8bc3052
@github-actions
Copy link

github-actions bot commented Dec 2, 2021

This functionality has been released in v3.68.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@max-lobur max-lobur mentioned this pull request Dec 6, 2021
Merged
@husseinmimiHarri husseinmimiHarri mentioned this pull request Jan 26, 2022
Open
@anGie44 anGie44 mentioned this pull request Feb 6, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jun 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit left review comments

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.68.0
Development

Successfully merging this pull request may close these issues.

aws_s3_bucket_replication_configuration: event_threshold block in metrics should not be required
3 participants
@anGie44 @robmp @ewbankkit