Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: aws_lambda_function #2721

Closed
wants to merge 3 commits into from
Closed

New Data Source: aws_lambda_function #2721

wants to merge 3 commits into from

Conversation

ian-d
Copy link
Contributor

@ian-d ian-d commented Dec 20, 2017

Resolves #2578.

Took a stab at creating the new aws_lambda_function data source. The qualifier property is a bit weird, but it's because of the way the AWS SDK handles it. If you supply an alias you get the actual version number back as Version. If you supply nothing you get $LATEST. So the resulting version property of the data source may end up being a version number or $LATEST.

make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceLambdaFunction'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccDataSourceLambdaFunction -timeout 120m
=== RUN   TestAccDataSourceLambdaFunction_basic
--- PASS: TestAccDataSourceLambdaFunction_basic (37.71s)
=== RUN   TestAccDataSourceLambdaFunction_alias
--- PASS: TestAccDataSourceLambdaFunction_alias (35.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	73.246s

@jen20 jen20 added the new-data-source Introduces a new data source. label Dec 20, 2017
@ian-d
Copy link
Contributor Author

ian-d commented Jan 11, 2018

Updated test runs from 45aae05.

make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceLambdaFunction'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccDataSourceLambdaFunction -timeout 120m
=== RUN   TestAccDataSourceLambdaFunction_basic
--- PASS: TestAccDataSourceLambdaFunction_basic (36.52s)
=== RUN   TestAccDataSourceLambdaFunction_alias
--- PASS: TestAccDataSourceLambdaFunction_alias (35.09s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	71.648s

@radeksimko radeksimko added the service/lambda Issues and PRs that pertain to the lambda service. label Jan 12, 2018
@radeksimko radeksimko changed the title Add aws_lambda_function data source. New Data Source: aws_lambda_function Jan 16, 2018
@ian-d
Copy link
Contributor Author

ian-d commented Jan 17, 2018

Closing, #2984 is a much better implementation.

@ian-d ian-d closed this Jan 17, 2018
@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-data-source Introduces a new data source. service/lambda Issues and PRs that pertain to the lambda service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Data Source for Lambda function
3 participants