Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_lambda_permission(test): rm unnecessary s3 bucket acl config #32827

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Aug 2, 2023

Description

Fixes TestAccLambdaPermission_s3. Ex.

=== CONT  TestAccLambdaPermission_s3
    permission_test.go:538: Step 1/2 error: Error running apply: exit status 1
        Error: creating S3 bucket ACL for tf-acc-test-2858722411593140646: AccessControlListNotSupported: The bucket does not allow ACLs
          status code: 400, request id: A3AWWVHDKM1Z3CTF, host id: Xo+b7xd9YhwQ+wYRq1MJWl/3ArXHAFHoKLXm7rt52xS8Y2X39Nyn+0Fq187aK3uhHu8HuRTEhFk=
          with aws_s3_bucket_acl.test,
          on terraform_plugin_test.tf line 42, in resource "aws_s3_bucket_acl" "test":
          42: resource "aws_s3_bucket_acl" "test" {
--- FAIL: TestAccLambdaPermission_s3 (164.94s)

Relations

Relates #28353

References

Output from Acceptance Testing

$ make testacc PKG=lambda TESTS=TestAccLambdaPermission_s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaPermission_s3'  -timeout 180m
=== RUN   TestAccLambdaPermission_s3
=== PAUSE TestAccLambdaPermission_s3
=== CONT  TestAccLambdaPermission_s3
--- PASS: TestAccLambdaPermission_s3 (35.95s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lambda     39.009s

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lambda Issues and PRs that pertain to the lambda service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Aug 2, 2023
@jar-b jar-b merged commit 051bf8a into main Aug 2, 2023
@jar-b jar-b deleted the td-lambda-testfix branch August 2, 2023 19:36
@github-actions github-actions bot added this to the v5.11.0 milestone Aug 2, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

This functionality has been released in v5.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/lambda Issues and PRs that pertain to the lambda service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant