Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace AWS Region metadata from names with endpoints #40335

Merged
merged 304 commits into from
Nov 28, 2024
Merged

Replace AWS Region metadata from names with endpoints #40335

merged 304 commits into from
Nov 28, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Nov 27, 2024 •
edited
Loading

Description

Replaces AWS Region metadata from this repository's names package with the equivalent endpoints from aws-sdk-go-base.

Relations

Relates #39874.
Relates #39873.
Relates hashicorp/aws-sdk-go-base#1176.

Output from Acceptance Testing

% make sane
make: Sane Check (48 tests of Top 30 resources)
make: Like 'sanity' except full output and stops soon after 1st error
make: NOTE: NOT an exhaustive set of tests! Finds big problems only.
2024/11/27 16:10:51 Initializing Terraform AWS Provider...
=== RUN   TestAccIAMInstanceProfile_tags
=== PAUSE TestAccIAMInstanceProfile_tags
=== RUN   TestAccIAMInstanceProfile_tags_null
=== PAUSE TestAccIAMInstanceProfile_tags_null
=== RUN   TestAccIAMInstanceProfile_tags_EmptyMap
=== PAUSE TestAccIAMInstanceProfile_tags_EmptyMap
=== RUN   TestAccIAMInstanceProfile_tags_AddOnUpdate
=== PAUSE TestAccIAMInstanceProfile_tags_AddOnUpdate
=== RUN   TestAccIAMInstanceProfile_tags_EmptyTag_OnCreate
=== PAUSE TestAccIAMInstanceProfile_tags_EmptyTag_OnCreate
=== RUN   TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_providerOnly
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_providerOnly
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_nonOverlapping
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_overlapping
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_overlapping
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccIAMInstanceProfile_tags_ComputedTag_OnCreate
=== PAUSE TestAccIAMInstanceProfile_tags_ComputedTag_OnCreate
=== RUN   TestAccIAMInstanceProfile_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccIAMInstanceProfile_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccIAMInstanceProfile_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccIAMInstanceProfile_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccIAMInstanceProfile_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccIAMInstanceProfile_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccIAMInstanceProfile_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccIAMInstanceProfile_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccIAMInstanceProfile_basic
=== PAUSE TestAccIAMInstanceProfile_basic
=== RUN   TestAccIAMPolicyDocumentDataSource_basic
=== PAUSE TestAccIAMPolicyDocumentDataSource_basic
=== RUN   TestAccIAMPolicyDocumentDataSource_sourceConflicting
=== PAUSE TestAccIAMPolicyDocumentDataSource_sourceConflicting
=== RUN   TestAccIAMPolicy_tags
=== PAUSE TestAccIAMPolicy_tags
=== RUN   TestAccIAMPolicy_tags_null
=== PAUSE TestAccIAMPolicy_tags_null
=== RUN   TestAccIAMPolicy_tags_EmptyMap
=== PAUSE TestAccIAMPolicy_tags_EmptyMap
=== RUN   TestAccIAMPolicy_tags_AddOnUpdate
=== PAUSE TestAccIAMPolicy_tags_AddOnUpdate
=== RUN   TestAccIAMPolicy_tags_EmptyTag_OnCreate
=== PAUSE TestAccIAMPolicy_tags_EmptyTag_OnCreate
=== RUN   TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccIAMPolicy_tags_DefaultTags_providerOnly
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_providerOnly
=== RUN   TestAccIAMPolicy_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_nonOverlapping
=== RUN   TestAccIAMPolicy_tags_DefaultTags_overlapping
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_overlapping
=== RUN   TestAccIAMPolicy_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccIAMPolicy_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccIAMPolicy_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccIAMPolicy_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccIAMPolicy_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccIAMPolicy_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccIAMPolicy_tags_ComputedTag_OnCreate
=== PAUSE TestAccIAMPolicy_tags_ComputedTag_OnCreate
=== RUN   TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccIAMPolicy_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccIAMPolicy_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccIAMPolicy_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccIAMPolicy_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccIAMPolicy_basic
=== PAUSE TestAccIAMPolicy_basic
=== RUN   TestAccIAMPolicy_policy
=== PAUSE TestAccIAMPolicy_policy
=== RUN   TestAccIAMPolicy_policyDuplicateKeys
=== PAUSE TestAccIAMPolicy_policyDuplicateKeys
=== RUN   TestAccIAMRolePolicyAttachment_basic
=== PAUSE TestAccIAMRolePolicyAttachment_basic
=== RUN   TestAccIAMRolePolicyAttachment_disappears
=== PAUSE TestAccIAMRolePolicyAttachment_disappears
=== RUN   TestAccIAMRolePolicyAttachment_Disappears_role
=== PAUSE TestAccIAMRolePolicyAttachment_Disappears_role
=== RUN   TestAccIAMRolePolicy_basic
=== PAUSE TestAccIAMRolePolicy_basic
=== RUN   TestAccIAMRolePolicy_unknownsInPolicy
=== PAUSE TestAccIAMRolePolicy_unknownsInPolicy
=== RUN   TestAccIAMRole_basic
=== PAUSE TestAccIAMRole_basic
=== RUN   TestAccIAMRole_namePrefix
=== PAUSE TestAccIAMRole_namePrefix
=== RUN   TestAccIAMRole_disappears
=== PAUSE TestAccIAMRole_disappears
=== RUN   TestAccIAMRole_InlinePolicy_basic
=== PAUSE TestAccIAMRole_InlinePolicy_basic
=== CONT  TestAccIAMInstanceProfile_tags
=== CONT  TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Add
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_nullNonOverlappingResourceTag
=== CONT  TestAccIAMPolicyDocumentDataSource_basic
=== CONT  TestAccIAMPolicy_tags_EmptyMap
=== CONT  TestAccIAMPolicy_tags
=== CONT  TestAccIAMInstanceProfile_tags_IgnoreTags_Overlap_DefaultTag
=== CONT  TestAccIAMPolicy_tags_EmptyTag_OnCreate
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_updateToResourceOnly
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_updateToProviderOnly
=== CONT  TestAccIAMInstanceProfile_basic
=== CONT  TestAccIAMPolicy_tags_null
=== CONT  TestAccIAMPolicy_tags_AddOnUpdate
=== CONT  TestAccIAMPolicyDocumentDataSource_sourceConflicting
=== CONT  TestAccIAMInstanceProfile_tags_ComputedTag_OnUpdate_Add
=== CONT  TestAccIAMInstanceProfile_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_nullOverlappingResourceTag
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_nonOverlapping
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_emptyProviderOnlyTag
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccIAMPolicyDocumentDataSource_basic (12.83s)
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_overlapping
--- PASS: TestAccIAMPolicyDocumentDataSource_sourceConflicting (12.96s)
=== CONT  TestAccIAMInstanceProfile_tags_ComputedTag_OnCreate
--- PASS: TestAccIAMInstanceProfile_basic (27.94s)
=== CONT  TestAccIAMInstanceProfile_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccIAMPolicy_tags_null (29.15s)
=== CONT  TestAccIAMInstanceProfile_tags_EmptyTag_OnCreate
--- PASS: TestAccIAMPolicy_tags_EmptyMap (29.67s)
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_providerOnly
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_nullNonOverlappingResourceTag (32.98s)
=== CONT  TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_nullOverlappingResourceTag (34.05s)
=== CONT  TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_emptyResourceTag (34.11s)
=== CONT  TestAccIAMInstanceProfile_tags_EmptyMap
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_emptyProviderOnlyTag (34.14s)
=== CONT  TestAccIAMInstanceProfile_tags_AddOnUpdate
--- PASS: TestAccIAMPolicy_tags_AddOnUpdate (37.72s)
=== CONT  TestAccIAMInstanceProfile_tags_null
--- PASS: TestAccIAMPolicy_tags_EmptyTag_OnCreate (40.76s)
=== CONT  TestAccIAMPolicy_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccIAMInstanceProfile_tags_ComputedTag_OnCreate (31.55s)
=== CONT  TestAccIAMRole_InlinePolicy_basic
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_updateToResourceOnly (45.66s)
=== CONT  TestAccIAMRole_disappears
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_updateToProviderOnly (54.32s)
=== CONT  TestAccIAMRole_namePrefix
--- PASS: TestAccIAMInstanceProfile_tags_ComputedTag_OnUpdate_Replace (55.84s)
=== CONT  TestAccIAMPolicy_tags_DefaultTags_emptyResourceTag
=== CONT  TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Add (56.35s)
--- PASS: TestAccIAMInstanceProfile_tags_ComputedTag_OnUpdate_Add (57.40s)
=== CONT  TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccIAMInstanceProfile_tags_IgnoreTags_Overlap_DefaultTag (63.22s)
=== CONT  TestAccIAMPolicy_tags_ComputedTag_OnCreate
--- PASS: TestAccIAMRole_disappears (18.77s)
=== CONT  TestAccIAMPolicy_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccIAMInstanceProfile_tags_EmptyMap (34.73s)
=== CONT  TestAccIAMPolicy_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccIAMInstanceProfile_tags_null (32.72s)
=== CONT  TestAccIAMPolicy_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccIAMRole_namePrefix (20.22s)
=== CONT  TestAccIAMRolePolicyAttachment_disappears
--- PASS: TestAccIAMPolicy_tags_DefaultTags_emptyResourceTag (24.12s)
=== CONT  TestAccIAMRole_basic
--- PASS: TestAccIAMPolicy_tags (79.96s)
=== CONT  TestAccIAMRolePolicy_unknownsInPolicy
--- PASS: TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Replace (50.01s)
=== CONT  TestAccIAMRolePolicy_basic
--- PASS: TestAccIAMInstanceProfile_tags_AddOnUpdate (52.54s)
=== CONT  TestAccIAMRolePolicyAttachment_Disappears_role
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_nonOverlapping (86.74s)
=== CONT  TestAccIAMPolicy_tags_DefaultTags_overlapping
--- PASS: TestAccIAMInstanceProfile_tags_EmptyTag_OnCreate (57.64s)
=== CONT  TestAccIAMPolicy_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccIAMPolicy_tags_IgnoreTags_Overlap_DefaultTag (48.74s)
=== CONT  TestAccIAMPolicy_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccIAMPolicy_tags_DefaultTags_nullNonOverlappingResourceTag (25.22s)
=== CONT  TestAccIAMPolicy_policy
=== CONT  TestAccIAMRolePolicyAttachment_basic
--- PASS: TestAccIAMPolicy_tags_ComputedTag_OnCreate (28.65s)
--- PASS: TestAccIAMRole_InlinePolicy_basic (48.32s)
=== CONT  TestAccIAMPolicy_policyDuplicateKeys
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_overlapping (80.01s)
=== CONT  TestAccIAMPolicy_basic
--- PASS: TestAccIAMRolePolicyAttachment_disappears (18.59s)
=== CONT  TestAccIAMPolicy_tags_DefaultTags_providerOnly
--- PASS: TestAccIAMPolicy_tags_DefaultTags_nullOverlappingResourceTag (24.90s)
=== CONT  TestAccIAMPolicy_tags_DefaultTags_nonOverlapping
--- PASS: TestAccIAMPolicy_policyDuplicateKeys (1.53s)
=== CONT  TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccIAMPolicy_tags_DefaultTags_emptyProviderOnlyTag (24.21s)
=== CONT  TestAccIAMPolicy_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Replace (44.24s)
--- PASS: TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Add (44.15s)
--- PASS: TestAccIAMRolePolicy_unknownsInPolicy (21.65s)
--- PASS: TestAccIAMRole_basic (22.04s)
--- PASS: TestAccIAMInstanceProfile_tags_IgnoreTags_Overlap_ResourceTag (75.33s)
--- PASS: TestAccIAMRolePolicy_basic (20.93s)
--- PASS: TestAccIAMRolePolicyAttachment_Disappears_role (18.42s)
--- PASS: TestAccIAMInstanceProfile_tags (106.95s)
--- PASS: TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Add (75.82s)
--- PASS: TestAccIAMPolicy_basic (17.96s)
--- PASS: TestAccIAMPolicy_policy (27.89s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_updateToResourceOnly (30.76s)
--- PASS: TestAccIAMRolePolicyAttachment_basic (26.89s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_updateToProviderOnly (31.21s)
--- PASS: TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Replace (28.79s)
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_providerOnly (98.48s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_overlapping (46.46s)
--- PASS: TestAccIAMPolicy_tags_IgnoreTags_Overlap_ResourceTag (39.13s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_nonOverlapping (43.02s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_providerOnly (54.67s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	153.330s
2024/11/27 16:13:56 Initializing Terraform AWS Provider...
=== RUN   TestAccLogsGroup_basic
=== PAUSE TestAccLogsGroup_basic
=== RUN   TestAccLogsGroup_multiple
=== PAUSE TestAccLogsGroup_multiple
=== CONT  TestAccLogsGroup_basic
=== CONT  TestAccLogsGroup_multiple
--- PASS: TestAccLogsGroup_multiple (12.32s)
--- PASS: TestAccLogsGroup_basic (15.69s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	21.315s
2024/11/27 16:14:11 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCDataSource_basic
=== PAUSE TestAccVPCDataSource_basic
=== RUN   TestAccVPCRouteTableAssociation_Subnet_basic
=== PAUSE TestAccVPCRouteTableAssociation_Subnet_basic
=== RUN   TestAccVPCRouteTable_basic
=== PAUSE TestAccVPCRouteTable_basic
=== RUN   TestAccVPCSecurityGroupRule_race
=== PAUSE TestAccVPCSecurityGroupRule_race
=== RUN   TestAccVPCSecurityGroupRule_protocolChange
=== PAUSE TestAccVPCSecurityGroupRule_protocolChange
=== RUN   TestAccVPCSecurityGroup_basic
=== PAUSE TestAccVPCSecurityGroup_basic
=== RUN   TestAccVPCSecurityGroup_egressMode
=== PAUSE TestAccVPCSecurityGroup_egressMode
=== RUN   TestAccVPCSecurityGroup_vpcAllEgress
=== PAUSE TestAccVPCSecurityGroup_vpcAllEgress
=== RUN   TestAccVPCSubnet_basic
=== PAUSE TestAccVPCSubnet_basic
=== RUN   TestAccVPC_tenancy
=== PAUSE TestAccVPC_tenancy
=== CONT  TestAccVPCDataSource_basic
=== CONT  TestAccVPCSecurityGroup_basic
=== CONT  TestAccVPCSubnet_basic
=== CONT  TestAccVPCSecurityGroup_vpcAllEgress
=== CONT  TestAccVPCSecurityGroup_egressMode
=== CONT  TestAccVPCSecurityGroupRule_race
=== CONT  TestAccVPCSecurityGroupRule_protocolChange
=== CONT  TestAccVPC_tenancy
=== CONT  TestAccVPCRouteTable_basic
=== CONT  TestAccVPCRouteTableAssociation_Subnet_basic
--- PASS: TestAccVPCSubnet_basic (20.01s)
--- PASS: TestAccVPCRouteTable_basic (20.16s)
--- PASS: TestAccVPCSecurityGroup_basic (21.62s)
--- PASS: TestAccVPCSecurityGroup_vpcAllEgress (22.84s)
--- PASS: TestAccVPCRouteTableAssociation_Subnet_basic (23.66s)
--- PASS: TestAccVPCDataSource_basic (28.53s)
--- PASS: TestAccVPCSecurityGroup_egressMode (42.17s)
--- PASS: TestAccVPC_tenancy (42.77s)
--- PASS: TestAccVPCSecurityGroupRule_protocolChange (50.07s)
--- PASS: TestAccVPCSecurityGroupRule_race (161.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	182.556s
2024/11/27 16:14:03 Initializing Terraform AWS Provider...
=== RUN   TestAccECSService_basic
=== PAUSE TestAccECSService_basic
=== RUN   TestAccECSService_basicImport
=== PAUSE TestAccECSService_basicImport
=== RUN   TestAccECSTaskDefinition_basic
=== PAUSE TestAccECSTaskDefinition_basic
=== CONT  TestAccECSService_basic
=== CONT  TestAccECSTaskDefinition_basic
=== CONT  TestAccECSService_basicImport
--- PASS: TestAccECSTaskDefinition_basic (21.92s)
--- PASS: TestAccECSService_basic (78.59s)
--- PASS: TestAccECSService_basicImport (194.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	207.981s
2024/11/27 16:13:59 Initializing Terraform AWS Provider...
=== RUN   TestAccELBV2TargetGroup_basic
=== PAUSE TestAccELBV2TargetGroup_basic
=== CONT  TestAccELBV2TargetGroup_basic
--- PASS: TestAccELBV2TargetGroup_basic (20.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	29.477s
2024/11/27 16:14:07 Initializing Terraform AWS Provider...
=== RUN   TestAccKMSKey_basic
=== PAUSE TestAccKMSKey_basic
=== CONT  TestAccKMSKey_basic
--- PASS: TestAccKMSKey_basic (23.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kms	40.496s
2024/11/27 16:17:51 Initializing Terraform AWS Provider...
=== RUN   TestAccLambdaFunction_basic
=== PAUSE TestAccLambdaFunction_basic
=== RUN   TestAccLambdaPermission_basic
=== PAUSE TestAccLambdaPermission_basic
=== CONT  TestAccLambdaFunction_basic
=== CONT  TestAccLambdaPermission_basic
--- PASS: TestAccLambdaPermission_basic (29.22s)
--- PASS: TestAccLambdaFunction_basic (41.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	54.861s
2024/11/27 16:17:47 Initializing Terraform AWS Provider...
=== RUN   TestAccMetaPartitionDataSource_basic
=== PAUSE TestAccMetaPartitionDataSource_basic
=== RUN   TestAccMetaRegionDataSource_basic
=== PAUSE TestAccMetaRegionDataSource_basic
=== RUN   TestAccMetaRegionDataSource_endpoint
=== PAUSE TestAccMetaRegionDataSource_endpoint
=== RUN   TestAccMetaRegionDataSource_endpointAndName
=== PAUSE TestAccMetaRegionDataSource_endpointAndName
=== CONT  TestAccMetaPartitionDataSource_basic
=== CONT  TestAccMetaRegionDataSource_endpoint
=== CONT  TestAccMetaRegionDataSource_endpointAndName
=== CONT  TestAccMetaRegionDataSource_basic
--- PASS: TestAccMetaRegionDataSource_basic (9.51s)
--- PASS: TestAccMetaPartitionDataSource_basic (9.56s)
--- PASS: TestAccMetaRegionDataSource_endpoint (10.12s)
--- PASS: TestAccMetaRegionDataSource_endpointAndName (10.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/meta	19.629s
2024/11/27 16:17:43 Initializing Terraform AWS Provider...
=== RUN   TestAccRoute53Record_basic
=== PAUSE TestAccRoute53Record_basic
=== RUN   TestAccRoute53Record_Latency_basic
=== PAUSE TestAccRoute53Record_Latency_basic
=== RUN   TestAccRoute53ZoneDataSource_name
=== PAUSE TestAccRoute53ZoneDataSource_name
=== RUN   TestAccRoute53ZoneDataSource_name_idEmptyString
=== PAUSE TestAccRoute53ZoneDataSource_name_idEmptyString
=== CONT  TestAccRoute53Record_basic
=== CONT  TestAccRoute53ZoneDataSource_name
=== CONT  TestAccRoute53ZoneDataSource_name_idEmptyString
=== CONT  TestAccRoute53Record_Latency_basic
--- PASS: TestAccRoute53ZoneDataSource_name (87.80s)
--- PASS: TestAccRoute53ZoneDataSource_name_idEmptyString (92.40s)
--- PASS: TestAccRoute53Record_Latency_basic (175.90s)
--- PASS: TestAccRoute53Record_basic (190.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	195.672s
2024/11/27 16:17:55 Initializing Terraform AWS Provider...
=== RUN   TestAccS3BucketACL_updateACL
=== PAUSE TestAccS3BucketACL_updateACL
=== RUN   TestAccS3BucketPolicy_basic
=== PAUSE TestAccS3BucketPolicy_basic
=== RUN   TestAccS3BucketPublicAccessBlock_basic
=== PAUSE TestAccS3BucketPublicAccessBlock_basic
=== RUN   TestAccS3Bucket_Basic_basic
=== PAUSE TestAccS3Bucket_Basic_basic
=== RUN   TestAccS3Bucket_Security_corsUpdate
=== PAUSE TestAccS3Bucket_Security_corsUpdate
=== CONT  TestAccS3BucketACL_updateACL
=== CONT  TestAccS3Bucket_Basic_basic
=== CONT  TestAccS3BucketPublicAccessBlock_basic
=== CONT  TestAccS3Bucket_Security_corsUpdate
=== CONT  TestAccS3BucketPolicy_basic
--- PASS: TestAccS3BucketPolicy_basic (19.99s)
--- PASS: TestAccS3BucketPublicAccessBlock_basic (19.99s)
--- PASS: TestAccS3Bucket_Basic_basic (20.34s)
--- PASS: TestAccS3BucketACL_updateACL (32.47s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (33.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	49.799s
2024/11/27 16:18:03 Initializing Terraform AWS Provider...
=== RUN   TestAccSecretsManagerSecret_basic
=== PAUSE TestAccSecretsManagerSecret_basic
=== RUN   TestAccSecretsManagerSecret_basicReplica
=== PAUSE TestAccSecretsManagerSecret_basicReplica
=== CONT  TestAccSecretsManagerSecret_basic
=== CONT  TestAccSecretsManagerSecret_basicReplica
--- PASS: TestAccSecretsManagerSecret_basic (14.33s)
--- PASS: TestAccSecretsManagerSecret_basicReplica (16.50s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager	41.210s
2024/11/27 16:17:59 Initializing Terraform AWS Provider...
=== RUN   TestAccSTSCallerIdentityDataSource_basic
=== PAUSE TestAccSTSCallerIdentityDataSource_basic
=== CONT  TestAccSTSCallerIdentityDataSource_basic
--- PASS: TestAccSTSCallerIdentityDataSource_basic (8.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sts	29.158s

@ewbankkit
Make 'AWSClient.AccountID' a getter - dlm.
1d91435
@ewbankkit
Make 'AWSClient.AccountID' a getter - dms.
5267499
@ewbankkit
Make 'AWSClient.AccountID' a getter - docdb.
2dfdd0d
@ewbankkit
Make 'AWSClient.AccountID' a getter - dynamodb.
6b4acfc
@ewbankkit
Make 'AWSClient.AccountID' a getter - ec2.
35dbb14
@ewbankkit
Make 'AWSClient.AccountID' a getter - ecr.
9d60ade
@ewbankkit
Make 'AWSClient.AccountID' a getter - ecrpublic.
dc3fa16
@ewbankkit
Make 'AWSClient.AccountID' a getter - ecs.
0f039bc
@ewbankkit
Make 'AWSClient.AccountID' a getter - efs.
4758e20
@ewbankkit
Make 'AWSClient.AccountID' a getter - eks.
69af5e9
@ewbankkit
Make 'AWSClient.AccountID' a getter - elasticache.
8a06d2f
@ewbankkit
Make 'AWSClient.AccountID' a getter - elasticbeanstalk.
71106b5
@ewbankkit
Make 'AWSClient.AccountID' a getter - elasticsearch.
445b874
@ewbankkit
Make 'AWSClient.AccountID' a getter - elastictranscoder.
ee15e48
@ewbankkit
Make 'AWSClient.AccountID' a getter - elb.
6068560
@ewbankkit
Make 'AWSClient.AccountID' a getter - elbv2.
bd0354a
@ewbankkit
Make 'AWSClient.AccountID' a getter - emr.
9df8ca1
@ewbankkit
Make 'AWSClient.AccountID' a getter - emrserverless.
2d4a431
@ewbankkit
Make 'AWSClient.AccountID' a getter - events.
7b03cf5
@ewbankkit
Make 'AWSClient.AccountID' a getter - evidently.
6aec0f8
@ewbankkit
Make 'AWSClient.AccountID' a getter - finspace.
2eb91ed
@ewbankkit
Make 'AWSClient.AccountID' a getter - fis.
3cd0139
@ewbankkit
Make 'AWSClient.AccountID' a getter - fms.
b5577ca
@ewbankkit
Make 'AWSClient.AccountID' a getter - fsx.
328a1c1
@ewbankkit
Make 'AWSClient.AccountID' a getter - gamelift.
526091d
@ewbankkit
Make 'AWSClient.AccountID' a getter - glacier.
e748f3e
@ewbankkit
Make 'AWSClient.AccountID' a getter - globalaccelerator.
b2d5bbc
@ewbankkit
Make 'AWSClient.AccountID' a getter - glue.
5701704
@ewbankkit
Make 'AWSClient.AccountID' a getter - grafana.
10c7e2f
@ewbankkit
Make 'AWSClient.AccountID' a getter - guardduty.
244c357
@github-actions github-actions bot added service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/dms Issues and PRs that pertain to the dms service. service/cognitoidentity Issues and PRs that pertain to the cognitoidentity service. service/ec2outposts Issues and PRs that pertain to the ec2outposts service. service/cur Issues and PRs that pertain to the cur service. service/evidently Issues and PRs that pertain to the evidently service. service/ec2ebs Issues and PRs that pertain to the ec2ebs service. service/finspace Issues and PRs that pertain to the finspace service. service/fis Issues and PRs that pertain to the fis service. service/emrserverless Issues and PRs that pertain to the emrserverless service. service/chimesdkmediapipelines Issues and PRs that pertain to the chimesdkmediapipelines service. service/docdbelastic Issues and PRs that pertain to the docdbelastic service. service/chimesdkvoice Issues and PRs that pertain to the chimesdkvoice service. service/cleanrooms Issues and PRs that pertain to the cleanrooms service. service/bedrock Issues and PRs that pertain to the bedrock service. service/appfabric Issues and PRs that pertain to the appfabric service. service/costoptimizationhub Issues and PRs that pertain to the costoptimizationhub service. service/datazone Issues and PRs that pertain to the datazone service. service/chatbot Issues and PRs that pertain to the chatbot service. labels Nov 27, 2024
gdavison
gdavison approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One non-blocking suggestion, otherwise looks good! 🚀

names/names.go Show resolved Hide resolved
@ewbankkit ewbankkit merged commit c2a971e into main Nov 28, 2024
40 checks passed
@ewbankkit ewbankkit deleted the td-names-use-endpoints-regions branch November 28, 2024 02:08
@github-actions github-actions bot added this to the v5.79.0 milestone Nov 28, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Nov 28, 2024
Update CHANGELOG.md for #40335
f75b604
@ewbankkit ewbankkit mentioned this pull request Nov 28, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

This functionality has been released in v5.79.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@ewbankkit ewbankkit mentioned this pull request Dec 17, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees
No one assigned
Labels
client-connections Pertains to the AWS Client and service connections. provider Pertains to the provider itself, rather than any interaction with AWS. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. service/account Issues and PRs that pertain to the account service. service/acm Issues and PRs that pertain to the acm service. service/acmpca Issues and PRs that pertain to the acmpca service. service/amp Issues and PRs that pertain to the amp service. service/amplify Issues and PRs that pertain to the amplify service. service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/appautoscaling Issues and PRs that pertain to the appautoscaling service. service/appconfig Issues and PRs that pertain to the appconfig service. service/appfabric Issues and PRs that pertain to the appfabric service. service/appflow Issues and PRs that pertain to the appflow service. service/applicationinsights Issues and PRs that pertain to the applicationinsights service. service/appmesh Issues and PRs that pertain to the appmesh service. service/apprunner Issues and PRs that pertain to the apprunner service. service/appstream Issues and PRs that pertain to the appstream service. service/appsync Issues and PRs that pertain to the appsync service. service/athena Issues and PRs that pertain to the athena service. service/auditmanager Issues and PRs that pertain to the auditmanager service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/backup Issues and PRs that pertain to the backup service. service/batch Issues and PRs that pertain to the batch service. service/bedrock Issues and PRs that pertain to the bedrock service. service/budgets Issues and PRs that pertain to the budgets service. service/ce Issues and PRs that pertain to the ce service. service/chatbot Issues and PRs that pertain to the chatbot service. service/chime Issues and PRs that pertain to the chime service. service/chimesdkmediapipelines Issues and PRs that pertain to the chimesdkmediapipelines service. service/chimesdkvoice Issues and PRs that pertain to the chimesdkvoice service. service/cleanrooms Issues and PRs that pertain to the cleanrooms service. service/cloud9 Issues and PRs that pertain to the cloud9 service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/cloudsearch Issues and PRs that pertain to the cloudsearch service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/codeartifact Issues and PRs that pertain to the codeartifact service. service/codebuild Issues and PRs that pertain to the codebuild service. service/codecommit Issues and PRs that pertain to the codecommit service. service/codegurureviewer Issues and PRs that pertain to the codegurureviewer service. service/codepipeline Issues and PRs that pertain to the codepipeline service. service/codestarconnections Issues and PRs that pertain to the codestarconnections service. service/codestarnotifications Issues and PRs that pertain to the codestarnotifications service. service/cognitoidentity Issues and PRs that pertain to the cognitoidentity service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/comprehend Issues and PRs that pertain to the comprehend service. service/computeoptimizer Issues and PRs that pertain to the computeoptimizer service. service/configservice Issues and PRs that pertain to the configservice service. service/connect Issues and PRs that pertain to the connect service. service/costoptimizationhub Issues and PRs that pertain to the costoptimizationhub service. service/cur Issues and PRs that pertain to the cur service. service/dataexchange Issues and PRs that pertain to the dataexchange service. service/datasync Issues and PRs that pertain to the datasync service. service/datazone Issues and PRs that pertain to the datazone service. service/dax Issues and PRs that pertain to the dax service. service/deploy Issues and PRs that pertain to the deploy service. service/detective Issues and PRs that pertain to the detective service. service/devicefarm Issues and PRs that pertain to the devicefarm service. service/devopsguru Issues and PRs that pertain to the devopsguru service. service/directconnect Issues and PRs that pertain to the directconnect service. service/dlm Issues and PRs that pertain to the dlm service. service/dms Issues and PRs that pertain to the dms service. service/docdb Issues and PRs that pertain to the docdb service. service/docdbelastic Issues and PRs that pertain to the docdbelastic service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/ec2ebs Issues and PRs that pertain to the ec2ebs service. service/ec2outposts Issues and PRs that pertain to the ec2outposts service. service/ec2 Issues and PRs that pertain to the ec2 service. service/ecr Issues and PRs that pertain to the ecr service. service/ecrpublic Issues and PRs that pertain to the ecrpublic service. service/ecs Issues and PRs that pertain to the ecs service. service/efs Issues and PRs that pertain to the efs service. service/eks Issues and PRs that pertain to the eks service. service/elasticache Issues and PRs that pertain to the elasticache service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/elastictranscoder Issues and PRs that pertain to the elastictranscoder service. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/emr Issues and PRs that pertain to the emr service. service/emrserverless Issues and PRs that pertain to the emrserverless service. service/events Issues and PRs that pertain to the events service. service/evidently Issues and PRs that pertain to the evidently service. service/finspace Issues and PRs that pertain to the finspace service. service/fis Issues and PRs that pertain to the fis service. service/fms Issues and PRs that pertain to the fms service. service/fsx Issues and PRs that pertain to the fsx service. service/gamelift Issues and PRs that pertain to the gamelift service. service/glacier Issues and PRs that pertain to the glacier service. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/glue Issues and PRs that pertain to the glue service. service/grafana Issues and PRs that pertain to the grafana service. service/guardduty Issues and PRs that pertain to the guardduty service. service/iam Issues and PRs that pertain to the iam service. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. service/inspector Issues and PRs that pertain to the inspector service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.79.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ewbankkit @gdavison