Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for get r53record host name #9965

Closed
wants to merge 3 commits into from
Closed

Workaround for get r53record host name #9965

wants to merge 3 commits into from

Conversation

Mochizuki-S2
Copy link

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #9024

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSRoute53Record'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSRoute53Record -timeout 120m
=== RUN   TestAccAWSRoute53Record_importBasic
=== PAUSE TestAccAWSRoute53Record_importBasic
=== RUN   TestAccAWSRoute53Record_importUnderscored
=== PAUSE TestAccAWSRoute53Record_importUnderscored
=== RUN   TestAccAWSRoute53Record_basic
=== PAUSE TestAccAWSRoute53Record_basic
=== RUN   TestAccAWSRoute53Record_disappears
=== PAUSE TestAccAWSRoute53Record_disappears
=== RUN   TestAccAWSRoute53Record_disappears_MultipleRecords
=== PAUSE TestAccAWSRoute53Record_disappears_MultipleRecords
=== RUN   TestAccAWSRoute53Record_basic_fqdn
=== PAUSE TestAccAWSRoute53Record_basic_fqdn
=== RUN   TestAccAWSRoute53Record_txtSupport
=== PAUSE TestAccAWSRoute53Record_txtSupport
=== RUN   TestAccAWSRoute53Record_spfSupport
=== PAUSE TestAccAWSRoute53Record_spfSupport
=== RUN   TestAccAWSRoute53Record_caaSupport
=== PAUSE TestAccAWSRoute53Record_caaSupport
=== RUN   TestAccAWSRoute53Record_generatesSuffix
=== PAUSE TestAccAWSRoute53Record_generatesSuffix
=== RUN   TestAccAWSRoute53Record_wildcard
=== PAUSE TestAccAWSRoute53Record_wildcard
=== RUN   TestAccAWSRoute53Record_failover
=== PAUSE TestAccAWSRoute53Record_failover
=== RUN   TestAccAWSRoute53Record_weighted_basic
=== PAUSE TestAccAWSRoute53Record_weighted_basic
=== RUN   TestAccAWSRoute53Record_weighted_to_simple_basic
=== PAUSE TestAccAWSRoute53Record_weighted_to_simple_basic
=== RUN   TestAccAWSRoute53Record_Alias_Elb
=== PAUSE TestAccAWSRoute53Record_Alias_Elb
=== RUN   TestAccAWSRoute53Record_Alias_S3
=== PAUSE TestAccAWSRoute53Record_Alias_S3
=== RUN   TestAccAWSRoute53Record_Alias_VpcEndpoint
=== PAUSE TestAccAWSRoute53Record_Alias_VpcEndpoint
=== RUN   TestAccAWSRoute53Record_Alias_Uppercase
=== PAUSE TestAccAWSRoute53Record_Alias_Uppercase
=== RUN   TestAccAWSRoute53Record_weighted_alias
=== PAUSE TestAccAWSRoute53Record_weighted_alias
=== RUN   TestAccAWSRoute53Record_geolocation_basic
=== PAUSE TestAccAWSRoute53Record_geolocation_basic
=== RUN   TestAccAWSRoute53Record_latency_basic
=== PAUSE TestAccAWSRoute53Record_latency_basic
=== RUN   TestAccAWSRoute53Record_TypeChange
=== PAUSE TestAccAWSRoute53Record_TypeChange
=== RUN   TestAccAWSRoute53Record_SetIdentifierChange
=== PAUSE TestAccAWSRoute53Record_SetIdentifierChange
=== RUN   TestAccAWSRoute53Record_AliasChange
=== PAUSE TestAccAWSRoute53Record_AliasChange
=== RUN   TestAccAWSRoute53Record_empty
=== PAUSE TestAccAWSRoute53Record_empty
=== RUN   TestAccAWSRoute53Record_longTXTrecord
=== PAUSE TestAccAWSRoute53Record_longTXTrecord
=== RUN   TestAccAWSRoute53Record_multivalue_answer_basic
=== PAUSE TestAccAWSRoute53Record_multivalue_answer_basic
=== RUN   TestAccAWSRoute53Record_allowOverwrite
=== PAUSE TestAccAWSRoute53Record_allowOverwrite
=== CONT  TestAccAWSRoute53Record_importBasic
=== CONT  TestAccAWSRoute53Record_allowOverwrite
=== CONT  TestAccAWSRoute53Record_multivalue_answer_basic
=== CONT  TestAccAWSRoute53Record_longTXTrecord
=== CONT  TestAccAWSRoute53Record_empty
=== CONT  TestAccAWSRoute53Record_AliasChange
=== CONT  TestAccAWSRoute53Record_SetIdentifierChange
=== CONT  TestAccAWSRoute53Record_TypeChange
=== CONT  TestAccAWSRoute53Record_latency_basic
=== CONT  TestAccAWSRoute53Record_geolocation_basic
=== CONT  TestAccAWSRoute53Record_weighted_alias
=== CONT  TestAccAWSRoute53Record_Alias_Uppercase
=== CONT  TestAccAWSRoute53Record_Alias_VpcEndpoint
=== CONT  TestAccAWSRoute53Record_Alias_S3
=== CONT  TestAccAWSRoute53Record_Alias_Elb
=== CONT  TestAccAWSRoute53Record_weighted_to_simple_basic
=== CONT  TestAccAWSRoute53Record_weighted_basic
=== CONT  TestAccAWSRoute53Record_failover
=== CONT  TestAccAWSRoute53Record_wildcard
=== CONT  TestAccAWSRoute53Record_generatesSuffix
--- PASS: TestAccAWSRoute53Record_Alias_Elb (177.53s)
=== CONT  TestAccAWSRoute53Record_caaSupport
--- PASS: TestAccAWSRoute53Record_empty (180.72s)
=== CONT  TestAccAWSRoute53Record_spfSupport
--- PASS: TestAccAWSRoute53Record_generatesSuffix (188.00s)
=== CONT  TestAccAWSRoute53Record_txtSupport
--- PASS: TestAccAWSRoute53Record_multivalue_answer_basic (189.98s)
=== CONT  TestAccAWSRoute53Record_basic_fqdn
--- PASS: TestAccAWSRoute53Record_weighted_basic (194.23s)
=== CONT  TestAccAWSRoute53Record_disappears_MultipleRecords
--- PASS: TestAccAWSRoute53Record_geolocation_basic (197.07s)
=== CONT  TestAccAWSRoute53Record_disappears
--- PASS: TestAccAWSRoute53Record_importBasic (197.24s)
=== CONT  TestAccAWSRoute53Record_basic
--- PASS: TestAccAWSRoute53Record_latency_basic (200.30s)
=== CONT  TestAccAWSRoute53Record_importUnderscored
--- PASS: TestAccAWSRoute53Record_Alias_Uppercase (200.67s)
--- PASS: TestAccAWSRoute53Record_longTXTrecord (203.69s)
--- PASS: TestAccAWSRoute53Record_Alias_S3 (203.66s)
--- PASS: TestAccAWSRoute53Record_failover (205.01s)
--- PASS: TestAccAWSRoute53Record_TypeChange (245.23s)
--- PASS: TestAccAWSRoute53Record_weighted_to_simple_basic (249.42s)
--- PASS: TestAccAWSRoute53Record_AliasChange (254.58s)
--- PASS: TestAccAWSRoute53Record_SetIdentifierChange (257.56s)
--- PASS: TestAccAWSRoute53Record_allowOverwrite (263.44s)
--- PASS: TestAccAWSRoute53Record_wildcard (276.48s)
--- PASS: TestAccAWSRoute53Record_caaSupport (141.82s)
--- PASS: TestAccAWSRoute53Record_spfSupport (141.11s)
--- PASS: TestAccAWSRoute53Record_txtSupport (148.02s)
--- PASS: TestAccAWSRoute53Record_disappears (143.88s)
--- PASS: TestAccAWSRoute53Record_importUnderscored (147.74s)
--- PASS: TestAccAWSRoute53Record_weighted_alias (351.63s)
--- PASS: TestAccAWSRoute53Record_basic_fqdn (167.72s)
--- PASS: TestAccAWSRoute53Record_disappears_MultipleRecords (191.40s)
--- PASS: TestAccAWSRoute53Record_basic (252.70s)
--- PASS: TestAccAWSRoute53Record_Alias_VpcEndpoint (581.86s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       581.966s

...

@Mochizuki-S2 Mochizuki-S2 requested a review from a team September 3, 2019 12:58
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/route53 Issues and PRs that pertain to the route53 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 3, 2019
@Mochizuki-S2 Mochizuki-S2 mentioned this pull request Sep 3, 2019
Closed
@aeschright aeschright added the bug Addresses a defect in current functionality. label Sep 3, 2019
@Mochizuki-S2
Merge remote-tracking branch 'upstream/master' into workaround-for-ge…
9a6e538 
…t-r53record-host

Conflicts:
	aws/resource_aws_route53_record_test.go
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Sep 25, 2019
@Mochizuki-S2 Mochizuki-S2 changed the title Workaround for get r53record host name [WIP] Workaround for get r53record host name Sep 25, 2019
@Mochizuki-S2 Mochizuki-S2 reopened this Sep 25, 2019
@Mochizuki-S2 Mochizuki-S2 changed the title [WIP] Workaround for get r53record host name Workaround for get r53record host name Sep 25, 2019
@Mochizuki-S2
Copy link
Author

I'm sorry, I didn't notice the conflict.

I fixed it and made testacc again.

Would you please code review again ?

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSRoute53Record'                                                                          ==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSRoute53Record -timeout 120m
=== RUN   TestAccAWSRoute53Record_basic
=== PAUSE TestAccAWSRoute53Record_basic
=== RUN   TestAccAWSRoute53Record_underscored
=== PAUSE TestAccAWSRoute53Record_underscored
=== RUN   TestAccAWSRoute53Record_disappears
=== PAUSE TestAccAWSRoute53Record_disappears
=== RUN   TestAccAWSRoute53Record_disappears_MultipleRecords
=== PAUSE TestAccAWSRoute53Record_disappears_MultipleRecords
=== RUN   TestAccAWSRoute53Record_basic_fqdn
=== PAUSE TestAccAWSRoute53Record_basic_fqdn
=== RUN   TestAccAWSRoute53Record_txtSupport
=== PAUSE TestAccAWSRoute53Record_txtSupport
=== RUN   TestAccAWSRoute53Record_spfSupport
=== PAUSE TestAccAWSRoute53Record_spfSupport
=== RUN   TestAccAWSRoute53Record_caaSupport
=== PAUSE TestAccAWSRoute53Record_caaSupport
=== RUN   TestAccAWSRoute53Record_generatesSuffix
=== PAUSE TestAccAWSRoute53Record_generatesSuffix
=== RUN   TestAccAWSRoute53Record_wildcard
=== PAUSE TestAccAWSRoute53Record_wildcard
=== RUN   TestAccAWSRoute53Record_failover
=== PAUSE TestAccAWSRoute53Record_failover
=== RUN   TestAccAWSRoute53Record_weighted_basic
=== PAUSE TestAccAWSRoute53Record_weighted_basic
=== RUN   TestAccAWSRoute53Record_weighted_to_simple_basic
=== PAUSE TestAccAWSRoute53Record_weighted_to_simple_basic
=== RUN   TestAccAWSRoute53Record_Alias_Elb
=== PAUSE TestAccAWSRoute53Record_Alias_Elb
=== RUN   TestAccAWSRoute53Record_Alias_S3
=== PAUSE TestAccAWSRoute53Record_Alias_S3
=== RUN   TestAccAWSRoute53Record_Alias_VpcEndpoint
=== PAUSE TestAccAWSRoute53Record_Alias_VpcEndpoint
=== RUN   TestAccAWSRoute53Record_Alias_Uppercase
=== PAUSE TestAccAWSRoute53Record_Alias_Uppercase
=== RUN   TestAccAWSRoute53Record_weighted_alias
=== PAUSE TestAccAWSRoute53Record_weighted_alias
=== RUN   TestAccAWSRoute53Record_geolocation_basic
=== PAUSE TestAccAWSRoute53Record_geolocation_basic
=== RUN   TestAccAWSRoute53Record_latency_basic
=== PAUSE TestAccAWSRoute53Record_latency_basic
=== RUN   TestAccAWSRoute53Record_TypeChange
=== PAUSE TestAccAWSRoute53Record_TypeChange
=== RUN   TestAccAWSRoute53Record_SetIdentifierChange
=== PAUSE TestAccAWSRoute53Record_SetIdentifierChange
=== RUN   TestAccAWSRoute53Record_AliasChange
=== PAUSE TestAccAWSRoute53Record_AliasChange
=== RUN   TestAccAWSRoute53Record_empty
=== PAUSE TestAccAWSRoute53Record_empty
=== RUN   TestAccAWSRoute53Record_longTXTrecord
=== PAUSE TestAccAWSRoute53Record_longTXTrecord
=== RUN   TestAccAWSRoute53Record_multivalue_answer_basic
=== PAUSE TestAccAWSRoute53Record_multivalue_answer_basic
=== RUN   TestAccAWSRoute53Record_allowOverwrite
=== PAUSE TestAccAWSRoute53Record_allowOverwrite
=== CONT  TestAccAWSRoute53Record_basic
=== CONT  TestAccAWSRoute53Record_allowOverwrite
=== CONT  TestAccAWSRoute53Record_multivalue_answer_basic
=== CONT  TestAccAWSRoute53Record_longTXTrecord
=== CONT  TestAccAWSRoute53Record_empty
=== CONT  TestAccAWSRoute53Record_AliasChange
=== CONT  TestAccAWSRoute53Record_SetIdentifierChange
=== CONT  TestAccAWSRoute53Record_TypeChange
=== CONT  TestAccAWSRoute53Record_latency_basic
=== CONT  TestAccAWSRoute53Record_geolocation_basic
=== CONT  TestAccAWSRoute53Record_weighted_alias
=== CONT  TestAccAWSRoute53Record_Alias_Uppercase
=== CONT  TestAccAWSRoute53Record_Alias_VpcEndpoint
=== CONT  TestAccAWSRoute53Record_Alias_S3
=== CONT  TestAccAWSRoute53Record_Alias_Elb
=== CONT  TestAccAWSRoute53Record_weighted_to_simple_basic
=== CONT  TestAccAWSRoute53Record_weighted_basic
=== CONT  TestAccAWSRoute53Record_failover
=== CONT  TestAccAWSRoute53Record_wildcard
=== CONT  TestAccAWSRoute53Record_generatesSuffix
--- PASS: TestAccAWSRoute53Record_weighted_basic (171.43s)
=== CONT  TestAccAWSRoute53Record_caaSupport
--- PASS: TestAccAWSRoute53Record_Alias_Uppercase (178.24s)
=== CONT  TestAccAWSRoute53Record_spfSupport
--- PASS: TestAccAWSRoute53Record_empty (178.93s)
=== CONT  TestAccAWSRoute53Record_txtSupport
--- PASS: TestAccAWSRoute53Record_longTXTrecord (187.77s)
=== CONT  TestAccAWSRoute53Record_basic_fqdn
--- PASS: TestAccAWSRoute53Record_geolocation_basic (197.18s)
=== CONT  TestAccAWSRoute53Record_disappears_MultipleRecords
--- PASS: TestAccAWSRoute53Record_latency_basic (198.92s)
=== CONT  TestAccAWSRoute53Record_disappears
--- PASS: TestAccAWSRoute53Record_generatesSuffix (205.68s)
=== CONT  TestAccAWSRoute53Record_underscored
--- PASS: TestAccAWSRoute53Record_multivalue_answer_basic (209.33s)
--- PASS: TestAccAWSRoute53Record_failover (213.04s)
--- PASS: TestAccAWSRoute53Record_Alias_Elb (216.13s)
--- PASS: TestAccAWSRoute53Record_Alias_S3 (218.10s)
--- PASS: TestAccAWSRoute53Record_allowOverwrite (236.05s)
--- PASS: TestAccAWSRoute53Record_SetIdentifierChange (253.91s)
--- PASS: TestAccAWSRoute53Record_wildcard (255.31s)
--- PASS: TestAccAWSRoute53Record_TypeChange (268.09s)
--- PASS: TestAccAWSRoute53Record_AliasChange (278.11s)
--- PASS: TestAccAWSRoute53Record_weighted_to_simple_basic (284.98s)
--- PASS: TestAccAWSRoute53Record_basic (287.06s)
--- PASS: TestAccAWSRoute53Record_spfSupport (143.35s)
--- PASS: TestAccAWSRoute53Record_txtSupport (142.70s)
--- PASS: TestAccAWSRoute53Record_caaSupport (151.51s)
--- PASS: TestAccAWSRoute53Record_disappears (154.33s)
--- PASS: TestAccAWSRoute53Record_weighted_alias (357.23s)
--- PASS: TestAccAWSRoute53Record_underscored (154.11s)
--- PASS: TestAccAWSRoute53Record_basic_fqdn (176.09s)
--- PASS: TestAccAWSRoute53Record_disappears_MultipleRecords (204.53s)
--- PASS: TestAccAWSRoute53Record_Alias_VpcEndpoint (535.39s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       535.477s

@Mochizuki-S2
Copy link
Author

Mochizuki-S2 commented Feb 17, 2020 •
edited
Loading

@jbergknoff-rival created cool pull request. ( #11335 )

I close this pull request in order to avoid confusion.

Please vote on #11335 by adding a 👍 reaction If you hope to resolve #9024

@Mochizuki-S2 Mochizuki-S2 deleted the workaround-for-get-r53record-host branch February 17, 2020 05:28
@ghost
Copy link

ghost commented Mar 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/route53 Issues and PRs that pertain to the route53 service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terraform apply does not delete Route53 record set while it says 'Resources: 1 added, 0 changed, 1 destroyed.'
2 participants
@Mochizuki-S2 @aeschright