Merge pull request #26136 from teowa/fix_TestDataSourcesWithAnEncrypt…

…ionBlockBehaveConsistently

provider - add exception for data source in unit test checking `encryption` block

internal/provider/provider_schema_test.go

@@ -433,19 +433,16 @@ func TestDataSourcesWithAnEncryptionBlockBehaveConsistently(t *testing.T) {
 
 	// TODO: 4.0 - work through this list
 	dataSourcesWhichNeedToBeAddressed := map[string]struct{}{
-		"azurerm_app_configuration": {},
-		"azurerm_batch_account":     {},
-		"azurerm_batch_pool":        {},
-		"azurerm_managed_disk":      {},
-		"azurerm_snapshot":          {},
+		"azurerm_managed_disk": {},
+		"azurerm_snapshot":     {},
 	}
 	if features.FourPointOhBeta() {
 		dataSourcesWhichNeedToBeAddressed = map[string]struct{}{}
 	}
 
 	for _, dataSourceName := range dataSourceNames {
 		dataSource := provider.DataSourcesMap[dataSourceName]
-		if err := schemaContainsAnEncryptionBlock(dataSource.Schema); err != nil {
+		if err := schemaContainsAnEncryptionBlock(dataSource.Schema, false); err != nil {
 			if _, ok := dataSourcesWhichNeedToBeAddressed[dataSourceName]; ok {
 				continue
 			}
@@ -490,7 +487,7 @@ func TestResourcesWithAnEncryptionBlockBehaveConsistently(t *testing.T) {
 	for _, resourceName := range resourceNames {
 		resource := provider.ResourcesMap[resourceName]
 
-		if err := schemaContainsAnEncryptionBlock(resource.Schema); err != nil {
+		if err := schemaContainsAnEncryptionBlock(resource.Schema, true); err != nil {
 			if _, ok := resourcesWhichNeedToBeAddressed[resourceName]; ok {
 				continue
 			}
@@ -499,7 +496,7 @@ func TestResourcesWithAnEncryptionBlockBehaveConsistently(t *testing.T) {
 	}
 }
 
-func schemaContainsAnEncryptionBlock(input map[string]*schema.Schema) error {
+func schemaContainsAnEncryptionBlock(input map[string]*schema.Schema, isResource bool) error {
 	// intentionally sorting these so the output is consistent
 	fieldNames := make([]string, 0)
 	for fieldName := range input {
@@ -513,7 +510,7 @@ func schemaContainsAnEncryptionBlock(input map[string]*schema.Schema) error {
 
 		if field.Type == pluginsdk.TypeList && field.Elem != nil {
 			if strings.Contains(key, "encryption") {
-				if field.Computed {
+				if isResource && field.Computed {
 					return fmt.Errorf("the block %q is marked as Computed when it shouldn't be", fieldName)
 				}
 
@@ -541,7 +538,7 @@ func schemaContainsAnEncryptionBlock(input map[string]*schema.Schema) error {
 			}
 
 			if val, ok := field.Elem.(*pluginsdk.Resource); ok && val.Schema != nil {
-				if err := schemaContainsAnEncryptionBlock(val.Schema); err != nil {
+				if err := schemaContainsAnEncryptionBlock(val.Schema, isResource); err != nil {
 					return fmt.Errorf("field %q: %+v", fieldName, err)
 				}
 			}