-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_virtual_network
- support for private_endpoint_vnet_policies
#27830
azurerm_virtual_network
- support for private_endpoint_vnet_policies
#27830
Conversation
location = azurerm_resource_group.test.location | ||
resource_group_name = azurerm_resource_group.test.name | ||
dns_servers = ["10.7.7.2", "10.7.7.7", "10.7.7.1", ] | ||
private_endpoint_vnet_policies = "Basic" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been set in the configuration for 3.x. Can you please set this in the configuration that will run in 4.x and also clean up the complete
config by removing the 3.x config that isn't valid anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
@stephybun , I found a regression issue. I will double check with service team first. |
@neil-yechenwei do you have an update on whether this is ready to go in? |
@stephybun , sorry. I am still checking with service team. |
@stephybun , service team has resolved the test issue. Below is the latest test result. Please take another look. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @neil-yechenwei LGTM 👍
* Update CHANGELOG.md for #28233 * Update for #28215 * Update CHANGELOG.md for #28279 * Update CHANGELOG.md #28269 * Update CHANGELOG.md #27876 * Update CHANGELOG.md #28069 * Update CHANGELOG.md for #28312 * Update CHANGELOG.md for #28278 * Update CHANGELOG.md #28311 * Update CHANGELOG.md undo 28311 * Update CHANGELOG.md #27874 * Update CHANGELOG.md * Update CHANGELOG for #28352 * Update CHANGELOG.md for #28390 * Update CHANGELOG.md for #28398 * Update CHANGELOG.md for #28425 * Update CHANGELOG.md #28427 * Update CHANGELOG.md #28280 * Update CHANGELOG.md for #28319 * Update CHANGELOG.md #24801 * Update for #28360 #28216 #27830 #28404 #27401 #27122 #27931 #28442 * Update for #28379 * Update CHANGELOG.md for #28281 * Update for #28380 * Update for #27375 * Update for #25695 * Update CHANGELOG.md #27985 * Update CHANGELOG.md - update release date manually until can be scripted * Update CHANGELOG.md revert date change as script available * pre-release script updates --------- Co-authored-by: stephybun <[email protected]> Co-authored-by: catriona-m <[email protected]> Co-authored-by: Wyatt Fry <[email protected]> Co-authored-by: sreallymatt <[email protected]> Co-authored-by: Matthew Frahry <[email protected]> Co-authored-by: kt <[email protected]>
…es` (hashicorp#27830) * azurerm_virtual_network - support for private_endpoint_vnet_policies * update tc
* Update CHANGELOG.md for hashicorp#28233 * Update for hashicorp#28215 * Update CHANGELOG.md for hashicorp#28279 * Update CHANGELOG.md hashicorp#28269 * Update CHANGELOG.md hashicorp#27876 * Update CHANGELOG.md hashicorp#28069 * Update CHANGELOG.md for hashicorp#28312 * Update CHANGELOG.md for hashicorp#28278 * Update CHANGELOG.md hashicorp#28311 * Update CHANGELOG.md undo 28311 * Update CHANGELOG.md hashicorp#27874 * Update CHANGELOG.md * Update CHANGELOG for hashicorp#28352 * Update CHANGELOG.md for hashicorp#28390 * Update CHANGELOG.md for hashicorp#28398 * Update CHANGELOG.md for hashicorp#28425 * Update CHANGELOG.md hashicorp#28427 * Update CHANGELOG.md hashicorp#28280 * Update CHANGELOG.md for hashicorp#28319 * Update CHANGELOG.md hashicorp#24801 * Update for hashicorp#28360 hashicorp#28216 hashicorp#27830 hashicorp#28404 hashicorp#27401 hashicorp#27122 hashicorp#27931 hashicorp#28442 * Update for hashicorp#28379 * Update CHANGELOG.md for hashicorp#28281 * Update for hashicorp#28380 * Update for hashicorp#27375 * Update for hashicorp#25695 * Update CHANGELOG.md hashicorp#27985 * Update CHANGELOG.md - update release date manually until can be scripted * Update CHANGELOG.md revert date change as script available * pre-release script updates --------- Co-authored-by: stephybun <[email protected]> Co-authored-by: catriona-m <[email protected]> Co-authored-by: Wyatt Fry <[email protected]> Co-authored-by: sreallymatt <[email protected]> Co-authored-by: Matthew Frahry <[email protected]> Co-authored-by: kt <[email protected]>
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Community Note
Description
Service team is requesting a new feature about
private_endpoint_vnet_policies
inazurerm_virtual_network
.API reference: https://github.com/Azure/azure-rest-api-specs/blob/a4fc4c6bda9ff2315671bca69f9de40a43e2bd8c/specification/network/resource-manager/Microsoft.Network/stable/2024-03-01/virtualNetwork.json#L2097
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_virtual_network
- support forprivate_endpoint_vnet_policies
This is a (please select all that apply):
Note
If this PR changes meaningfully during the course of review please update the title and description as required.