Add optional region field (#7770) (#5514)

* Add optional region field * Add field to example and test Signed-off-by: Modular Magician <[email protected]>
hashicorp · Apr 19, 2023 · 92469b3 · 92469b3
1 parent 944a050
commit 92469b3
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 2 deletions.
diff --git a/.changelog/7770.txt b/.changelog/7770.txt
@@ -0,0 +1,3 @@
+```release-note:enhancement
+vertexai: added `region` field to `google_vertex_ai_endpoint`
+```
diff --git a/google-beta/resource_vertex_ai_endpoint.go b/google-beta/resource_vertex_ai_endpoint.go
@@ -93,6 +93,12 @@ func ResourceVertexAIEndpoint() *schema.Resource {
 				ForceNew:    true,
 				Description: `The full name of the Google Compute Engine [network](https://cloud.google.com//compute/docs/networks-and-firewalls#networks) to which the Endpoint should be peered. Private services access must already be configured for the network. If left unspecified, the Endpoint is not peered with any network. Only one of the fields, network or enable_private_service_connect, can be set. [Format](https://cloud.google.com/compute/docs/reference/rest/v1/networks/insert): 'projects/{project}/global/networks/{network}'. Where '{project}' is a project number, as in '12345', and '{network}' is network name.`,
 			},
+			"region": {
+				Type:        schema.TypeString,
+				Optional:    true,
+				ForceNew:    true,
+				Description: `The region for the resource`,
+			},
 			"create_time": {
 				Type:        schema.TypeString,
 				Computed:    true,

diff --git a/google-beta/resource_vertex_ai_endpoint_test.go b/google-beta/resource_vertex_ai_endpoint_test.go
@@ -45,7 +45,7 @@ func TestAccVertexAIEndpoint_vertexAiEndpointNetwork(t *testing.T) {
 				ResourceName:            "google_vertex_ai_endpoint.endpoint",
 				ImportState:             true,
 				ImportStateVerify:       true,
-				ImportStateVerifyIgnore: []string{"etag", "location"},
+				ImportStateVerifyIgnore: []string{"etag", "location", "region"},
 			},
 			{
 				Config: testAccVertexAIEndpoint_vertexAiEndpointNetworkUpdate(context),
@@ -54,7 +54,7 @@ func TestAccVertexAIEndpoint_vertexAiEndpointNetwork(t *testing.T) {
 				ResourceName:            "google_vertex_ai_endpoint.endpoint",
 				ImportState:             true,
 				ImportStateVerify:       true,
-				ImportStateVerifyIgnore: []string{"etag", "location"},
+				ImportStateVerifyIgnore: []string{"etag", "location", "region"},
 			},
 		},
 	})
@@ -67,6 +67,7 @@ resource "google_vertex_ai_endpoint" "endpoint" {
   display_name = "sample-endpoint"
   description  = "A sample vertex endpoint"
   location     = "us-central1"
+  region       = "us-central1"
   labels       = {
     label-one = "value-one"
   }
@@ -114,6 +115,7 @@ resource "google_vertex_ai_endpoint" "endpoint" {
   display_name = "new-sample-endpoint"
   description  = "An updated sample vertex endpoint"
   location     = "us-central1"
+  region       = "us-central1"
   labels       = {
     label-two = "value-two"
   }

diff --git a/website/docs/r/vertex_ai_endpoint.html.markdown b/website/docs/r/vertex_ai_endpoint.html.markdown
@@ -37,6 +37,7 @@ resource "google_vertex_ai_endpoint" "endpoint" {
   display_name = "sample-endpoint"
   description  = "A sample vertex endpoint"
   location     = "us-central1"
+  region       = "us-central1"
   labels       = {
     label-one = "value-one"
   }
@@ -114,6 +115,10 @@ The following arguments are supported:
   (Optional)
   The full name of the Google Compute Engine [network](https://cloud.google.com//compute/docs/networks-and-firewalls#networks) to which the Endpoint should be peered. Private services access must already be configured for the network. If left unspecified, the Endpoint is not peered with any network. Only one of the fields, network or enable_private_service_connect, can be set. [Format](https://cloud.google.com/compute/docs/reference/rest/v1/networks/insert): `projects/{project}/global/networks/{network}`. Where `{project}` is a project number, as in `12345`, and `{network}` is network name.
 
+* `region` -
+  (Optional)
+  The region for the resource
+
 * `project` - (Optional) The ID of the project in which the resource belongs.
     If it is not provided, the provider project is used.