Deprecate DataProfileResult and DataQualityResult for Dataplex Datasc…

…ans. (#8593) (#6090)

Signed-off-by: Modular Magician <[email protected]>

.changelog/8593.txt

@@ -0,0 +1,3 @@
+```release-note:deprecation
+dataplex: deprecated the following `google_dataplex_datascan` fields: `dataProfileResult` and `dataQualityResult`
+```

.teamcity/components/generated/packages.kt

@@ -17,11 +17,6 @@ var packages = mapOf(
         "displayName" to "Environment Variables",
         "path" to "./google-beta/envvar"
     ),
-    "fwmodels" to mapOf(
-        "name" to "fwmodels",
-        "displayName" to "Framework Models",
-        "path" to "./google-beta/fwmodels"
-    ),
     "fwprovider" to mapOf(
         "name" to "fwprovider",
         "displayName" to "Framework Provider",

google-beta/services/dataplex/resource_dataplex_datascan.go

@@ -392,6 +392,7 @@ Only relevant if a minValue has been defined. Default = false.`,
 			"data_profile_result": {
 				Type:        schema.TypeList,
 				Computed:    true,
+				Deprecated:  "dataProfileResult will be removed from Terraform output fields in 5.0.0",
 				Description: `The result of the data profile scan.`,
 				Elem: &schema.Resource{
 					Schema: map[string]*schema.Schema{
@@ -608,6 +609,7 @@ Only relevant if a minValue has been defined. Default = false.`,
 			"data_quality_result": {
 				Type:        schema.TypeList,
 				Computed:    true,
+				Deprecated:  "dataQualityResult will be removed from Terraform output fields in 5.0.0",
 				Description: `The result of the data quality scan.`,
 				Elem: &schema.Resource{
 					Schema: map[string]*schema.Schema{

website/docs/guides/version_5_upgrade.html.markdown

@@ -190,6 +190,12 @@ These two unsupported fields were introduced incorrectly. They are now removed.
 
 This unsupported field was introduced incorrectly. It is now removed.
 
+## Resource: `google_dataplex_datascan`
+
+### `dataQualityResult` and `dataProfileResult` output fields are now removed 
+
+`dataQualityResult` and `dataProfileResult` were output-only fields which listed results for the latest job created under a Datascan. These were problematic fields that are unlikely to be relevant in a Terraform context. Removing them reduces the likelihood of additional parsing errors, and reduces maintenance overhead for the API surface.
+
 ## Resource: `google_compute_router_nat`
 
 ### `enable_endpoint_independent_mapping` now defaults to API's default value which is `FALSE`

website/docs/r/dataplex_datascan.html.markdown

@@ -499,10 +499,12 @@ In addition to the arguments listed above, the following computed attributes are
   The type of DataScan.
 
 * `data_quality_result` -
+  (Deprecated)
   The result of the data quality scan.
   Structure is [documented below](#nested_data_quality_result).
 
 * `data_profile_result` -
+  (Deprecated)
   The result of the data profile scan.
   Structure is [documented below](#nested_data_profile_result).