Replaced the panic statement with error in `google_secret_manager_sec…

…ret_version` resource import function (#8923) (#6296) Signed-off-by: Modular Magician <[email protected]>
hashicorp · Sep 18, 2023 · e2b55b3 · e2b55b3
1 parent 07ca3ed
commit e2b55b3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/.changelog/8923.txt b/.changelog/8923.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+secretmanager: replaced the panic block with an error in import function of `google_secret_manager_secret_version` resource
+```
diff --git a/google-beta/services/secretmanager/resource_secret_manager_secret_version.go b/google-beta/services/secretmanager/resource_secret_manager_secret_version.go
@@ -357,7 +357,7 @@ func resourceSecretManagerSecretVersionImport(d *schema.ResourceData, meta inter
 
 	parts := secretRegex.FindStringSubmatch(name)
 	if len(parts) != 2 {
-		panic(fmt.Sprintf("Version name does not fit the format `projects/{{project}}/secrets/{{secret}}/versions/{{version}}`"))
+		return nil, fmt.Errorf("Version name does not fit the format `projects/{{project}}/secrets/{{secret}}/versions/{{version}}`")
 	}
 	if err := d.Set("secret", parts[1]); err != nil {
 		return nil, fmt.Errorf("Error setting secret: %s", err)