Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared reservation #3980

Conversation

modular-magician
Copy link
Collaborator

Added shareSetting to enable SharedReservation creation for compute.reservation.
ShareSetting includes two properties:
-shareType: LOCAL and SPECIFIC_PROJECTS
-project_map: a map of projectId and projectConfig.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: Added `shareSettings` in `google_compute_reservation`

Derived from GoogleCloudPlatform/magic-modules#5547

* Adding shareSetting to create SherdReservations.

* Add ShareSetting to create sharedReservation.

* fixing the update test

* fixing sharedReservation test

* adding shareType local to instance test.

* fixing shareType issue.

* fixing shareType issue.

* fix ShareType issue.

* fix shareType issue.

* unde recent changes.

* provide digit validation for project_number.

* set ignore_read=true for shareSettings to enable project_id.

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 3cb5358 into hashicorp:master Jan 12, 2022
@modular-magician modular-magician deleted the downstream-pr-2bbfb88705d1ed17e5bd0240101ce2d8707228a9 branch November 16, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant