Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for image type configuration on the GKE NAP #4023

Conversation

modular-magician
Copy link
Collaborator

Since one of the image streaming requirements is having Container-Optimized OS with containers as node image and on the other side, if we use the Node Auto Provisioning, there's not any possibility to config auto_provisioning_defaults to set up the default image type to cos_containerd.
In this PR I added this feature to pass the image_type value on the NAP configuration.

Related issue: hashicorp/terraform-provider-google#10957

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: Added support for image type configuration on the GKE Node Auto-provisioning

Derived from GoogleCloudPlatform/magic-modules#5644

* Add support for image type configuration on the GKE NAP

* Add GA and Beta changes for image_type support on NAP

* Update validation for image_type on NAP

* Put image_type support on GA and change default its value to containerd

* Set ignoreCase as true on Validation function for image_type

Co-authored-by: megan07 <[email protected]>

* Image_type Capitalization

Co-authored-by: megan07 <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit f46e986 into hashicorp:master Feb 1, 2022
@modular-magician modular-magician deleted the downstream-pr-4d6348245c1446f2e47fe696bf35bbd38877ab3c branch November 16, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant