Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Cloud SQL Address Range Picker for Clones and Read replicas #4037

Conversation

modular-magician
Copy link
Collaborator

Fixes hashicorp/terraform-provider-google#11000

Also removed the ForceNew for allocated_ip_range field for primary instance update, as currently allocated IP range can not be updated only within a VPC - the field can be updated in place if we also update the private network. Therefore, recreation functionality should be added to this field in a general case. We could add a CustomizeDiff to only add ForceNew if allocated_ip_range is changed within a VPC, but I am not sure if that's something we want to add, as the API may change to include the update feature anytime, plus the allocated ip range does not support updating after creation using UI and I also wonder if users would appreciate recreation for sql instances in general.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

sql: added field `clone.allocated_ip_range` to support address range picker for clone for resource `google_sql_database_instance`
sql: added support for address range picker for read replicas for resource `google_sql_database_instance`

Derived from GoogleCloudPlatform/magic-modules#5664

@modular-magician modular-magician merged commit 6fc5a1e into hashicorp:master Feb 8, 2022
@modular-magician modular-magician deleted the downstream-pr-40e8735bb6b89e74a6c43a96a7601eddb07001fd branch November 16, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TF support for Cloud SQL Address Range Picker for Clones and Read replicas
1 participant