Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spanner): fix escaping of database name in spanner ddl with POSTGRES dialect #4228

Conversation

modular-magician
Copy link
Collaborator

Currently name attribute having - in value cannot be populated because of issue in escaping database name
e.g

variables "database_name" {
type = string
default = "dbatest5-postgres"
}

resource "google_spanner_database" "database" {
instance = google_spanner_instance.main.name
name = ""${var.database_name}""
database_dialect = "POSTGRESQL"
deletion_protection = false
}

This PR will fix the escaping with POSTGRES dialect

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

spanner: fix escaping of database names with Postgres dialect in `google_spanner_database`

Derived from GoogleCloudPlatform/magic-modules#5938

@modular-magician modular-magician merged commit c9a99b7 into hashicorp:main Apr 15, 2022
@modular-magician modular-magician deleted the downstream-pr-f2f95a7de22d4230da0210cc50bcb4212a44188b branch November 16, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant