Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMEK support for Cloud Functions #4272

Conversation

modular-magician
Copy link
Collaborator

In particular, this adds the support for two fields that are necessary for deploying CMEK-enabled functions: kms_key_name and docker_repository. Refer to the CMEK guide for Cloud Functions for more details.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudfunctions: CMEK support for Cloud Functions

Derived from GoogleCloudPlatform/magic-modules#5973

* CMEK support for Cloud Functions (docker_repository and kms_key_name fields)

* separate tests for CMEK and AR; added role binding for the CMEK test

* Remaining IAM configs

* Formatting

* Granting additional permissions to the service accounts

* Another attempts at fixing the IAM (potentially a race) issue

* Accounting for feedback: create kms key via bootstraping util

* documentation update

* Remove refernces to beta in the docs (feedback)

Co-authored-by: Rustem Bekmukhametov <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 8dff116 into hashicorp:main May 2, 2022
@modular-magician modular-magician deleted the downstream-pr-1eab143ed7c59baca4dc97b6f9504daa8469b217 branch November 16, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant