Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding JSONPath content matching fields. #4361

Conversation

modular-magician
Copy link
Collaborator

This PR adds support for the JSONPath content matchers for an Uptime Check. This lets users validate expected content is within the response of an Uptime Check probe, or that content is explicitly not present.

fixes hashicorp/terraform-provider-google#11777

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

monitoring: added support for JSONPath content matchers for Uptime Checks

Derived from GoogleCloudPlatform/magic-modules#6082

* Adding JSONPath content matching fields.

* Make json_path required if including json_path_matcher

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 66b554f into hashicorp:main Jun 3, 2022
@modular-magician modular-magician deleted the downstream-pr-537394a8a9ffbf224185ee9d80dccbf6c8b8d79f branch November 16, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uptime Checks - JSONPath
1 participant