Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_dns_managed_zone labels patching #4372

Conversation

modular-magician
Copy link
Collaborator

Fixes this issue wherein PATCH is used instead of PUT for google_dns_managed_zone, leading to the inability to remove labels from the resource (and thus a perma-diff).

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.
dns: fixed perma-diff for updated labels in `google_dns_managed_zone`

Derived from GoogleCloudPlatform/magic-modules#6062

* Switch to PATCH for google_dns_managed_zone

Signed-off-by: Trung <[email protected]>

* Limit changes to update_encoder

Signed-off-by: Trung <[email protected]>

* Fix dns managed zone labels test

Signed-off-by: Trung <[email protected]>

* Rename to managedZoneID

Signed-off-by: Trung <[email protected]>

* Documentation and ignore managed_zone_id and creation_time

Signed-off-by: Trung <[email protected]>

* Fix linter and comment format

Signed-off-by: Trung <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 2e8e88f into hashicorp:main Jun 7, 2022
@modular-magician modular-magician deleted the downstream-pr-45347f4a0b7b3c89894dfcde1d9cdc639d913bed branch November 16, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant