Handle email
-less services in google_project_service_identity
#4432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes hashicorp/terraform-provider-google#10367
This PR changes the
google_project_service_identity
resource to handle scenarios when it successfully creates a service identity for a given Google API via generateServiceIdentity but the response doesn't contain the service identity's email. Nowemail
will only be set if the response contains an email.The downside is that if the email isn't returned by the API, user won't know until they try to reference the email attribute elsewhere
Examples of the endpoint succeeding & returning an email, succeeding but not returning an email, and erroring:
$ gcloud beta services identity create --service=containerscanning.googleapis.com Service identity created: service-XXXXXXXXXX@gcp-sa-containerscanning.iam.gserviceaccount.com $ gcloud beta services identity create --service=logging.googleapis.com Service identity created $ gcloud beta services identity create --service=stackdriverprovisioning.googleapis.com ERROR: (gcloud.beta.services.identity.create) INVALID_ARGUMENT: Service stackdriverprovisioning.googleapis.com has not been configured for service identities.
Checklist
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#6192