Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle email-less services in google_project_service_identity #4432

Conversation

modular-magician
Copy link
Collaborator

Description

Closes hashicorp/terraform-provider-google#10367

This PR changes the google_project_service_identity resource to handle scenarios when it successfully creates a service identity for a given Google API via generateServiceIdentity but the response doesn't contain the service identity's email. Now email will only be set if the response contains an email.

The downside is that if the email isn't returned by the API, user won't know until they try to reference the email attribute elsewhere

Examples of the endpoint succeeding & returning an email, succeeding but not returning an email, and erroring:

$ gcloud beta services identity create --service=containerscanning.googleapis.com                    
Service identity created: service-XXXXXXXXXX@gcp-sa-containerscanning.iam.gserviceaccount.com

$ gcloud beta services identity create --service=logging.googleapis.com          
Service identity created

$ gcloud beta services identity create --service=stackdriverprovisioning.googleapis.com
ERROR: (gcloud.beta.services.identity.create) INVALID_ARGUMENT: Service stackdriverprovisioning.googleapis.com has not been configured for service identities.

Checklist

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

serviceusage: fixed an issue where `google_project_service_identity` didn't handle service identities without emails correctly (beta)

Derived from GoogleCloudPlatform/magic-modules#6192

@modular-magician modular-magician merged commit 2fa93a0 into hashicorp:main Jun 30, 2022
@modular-magician modular-magician deleted the downstream-pr-929c286b3c8dad349571de0953cc93953c21a94b branch November 16, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"google_project_service_identity" should handle an empty ServiceIdentity
1 participant