Add paused attribute to google_cloud_scheduler_job resource
#4535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icorp#6304) * Add `state` field to `google_cloud_scheduler_job` as output * Add `paused` field to `google_cloud_scheduler_job` to control state * Add example of paused `google_cloud_scheduler_job` * Add handwritten test for paused `google_cloud_scheduler_job` * Address make lint output * Make `paused` argument default to value derived from API via custom flatten function * Add comment to custom flatten function Signed-off-by: Modular Magician <[email protected]>
modular-magician
deleted the
downstream-pr-cf0f8233984bd8715c491cc72b27b42ea87b7023
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes hashicorp/terraform-provider-google#7883
This PR lets users control the state of the Cloud Scheduler Job as paused or enabled (default). Currently, if a Job is paused/resumed through the console that change made outside of Terraform isn't visible when creating plans.
I've added the
stateof the job as an output, and the newpausedfield controls calls to the projects.locations.jobs.pause and projects.locations.jobs.resume endpoints in post-create and post-update actions in the provider code to change the state.My rationale for including
stateas an output was to allow users to see the job's state in scenarios where it is neither paused or enabled, e.g in an error state due to some factor outside the Terraform config. I believe if that happened the projects.locations.jobs.pause / projects.locations.jobs.resume API calls would return an error, so users would also be notified about any issues via that route too.If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#6304