Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for network tags in Autopilot clusters and NAP node pools #4611

Conversation

modular-magician
Copy link
Collaborator

Hey, I took a stab at adding support for network tags on Autopilot clusters and NAP node pools. The placement and naming of the field were a bit tricky since the same API is used for both Autopilot and NAP, but I'm open to suggestions.

I also added a pair of new acceptance tests to go along with it that I believe should pass, but I haven't been able to run them since they violate my company's org-level GCP constraints. I did however do manual tests provisioning/updating autopilot clusters and they were successful. I expect NAP clusters should work fine given it's the same API call, but I wanted to get the PR submitted for comments and to make sure the acceptance tests run successfully.

fixes hashicorp/terraform-provider-google#11051

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: added field `auto_provisioning_network_tags` to `google_container_cluster` (beta)

Derived from GoogleCloudPlatform/magic-modules#6133

@modular-magician modular-magician merged commit 9ee5423 into hashicorp:main Aug 19, 2022
@modular-magician modular-magician deleted the downstream-pr-5822022efa8d98e2a2810a1392196a5708e33463 branch November 16, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform support for GKE Autopilot Network Tags
1 participant