Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for visible_core_count for google_compute_instance resource #4635

Conversation

modular-magician
Copy link
Collaborator

Adding support for visible cores under google_compute_instance resource https://cloud.google.com/compute/docs/instances/customize-visible-cores

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: Added support for param `visible_core_count` in `google_compute_instance` and `google_compute_instance_template` under `advanced_machine_features`

Derived from GoogleCloudPlatform/magic-modules#6414

…ce (hashicorp#6414)

* add support for threads per core

* adding missing comma

* add support for threads per core

* guard changes with beta flag

* fixing typo

* fixing value

* guarding changes with flags

* annoting doc attribute with beta tag

* annoting doc attribute with beta tag

* missing comma

* adding guards for beta params

* adding guards for beta params

* incoprated comments

* incoprated comments

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 9ae00b3 into hashicorp:main Aug 26, 2022
@modular-magician modular-magician deleted the downstream-pr-193287d755472594b48c6a85bbcc5d072b5d5238 branch November 16, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant