Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vertical whitespace and google.rpc.Help.Link output #4642

Conversation

modular-magician
Copy link
Collaborator

Output repeated google.rpc.Help.Link "description" and "url".

For Compute Operation errors, add vertical whitespace between the Error message the LocalizedMessage.message and each Help.Link "description" and "url".

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added support documentation links to error messages for certain Compute Operation errors.

Derived from GoogleCloudPlatform/magic-modules#6454

* Add vertical whitespace and google.rpc.Help.Link output

* remove one line from err msg separator

* only display the first help link

* add tests for ComputeOperationError.Error

* make erb so supports ga and beta

* dry off test for ComputeOperationError.Error

* omitAlways array needs to be dynamic

* ensure the first LocalizedMessage is used only

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit fe7e660 into hashicorp:main Aug 29, 2022
@modular-magician modular-magician deleted the downstream-pr-7d3b696f9a938695fbb3f6bf927b279d641fb95f branch November 16, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant