Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support serviceAccount field for AppEngine flex #4653

Conversation

modular-magician
Copy link
Collaborator

Fixes hashicorp/terraform-provider-google#11813

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

appengine: Added field `serviceAccount` to `app_engine_flexible_app_version`

Derived from GoogleCloudPlatform/magic-modules#6391

* Support serviceAccount field for AppEngine flex

* Add service account example

* Update account_id

* Use vars instead of test env vars

* Move account id to right tf example

* Update mmv1/templates/terraform/examples/app_engine_flexible_app_version.tf.erb

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* Add logs writer and network user role

* Update mmv1/templates/terraform/examples/app_engine_flexible_app_version.tf.erb

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* Add objectViewer role

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 724c9f3 into hashicorp:main Sep 2, 2022
@modular-magician modular-magician deleted the downstream-pr-f76af3c37b9f2d8f5bb144d7c3d52b1af0cb3a42 branch November 16, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support non default service accounts for AppEngine Flex
1 participant