Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add org_policy_custom_constraint resource #4741

Conversation

modular-magician
Copy link
Collaborator

Adds the org_policy_custom_constraint resource.

This feature is in public preview, so it will be released under the beta version of the provider. Note that there already exists an org_policy_policy resource that is implemented using the DCL.

b/243447088

Example:

resource "google_org_policy_custom_constraint" "constraint" {
  name         = "organizations/123/customConstraints/custom.disableGkeAutoUpgrade"
  parent       = "organizations/123"

  action_type    = "ALLOW"
  condition      = "resource.management.autoUpgrade == false"
  method_types   = ["CREATE", "UPDATE"]
  resource_types = ["container.googleapis.com/NodePool"]
}

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_org_policy_custom_constraint

Derived from GoogleCloudPlatform/magic-modules#6608

* Add org_policy_custom_constraint resource

* Update resource config to reflect beta version

* Update handwritten test to reflect beta version

* Update example to use beta version of the provider

* Remove unnecessary TestCheckResourceAttr calls

* Update name attribute to be specified as a shortname

* Add full example

* Tweak config and documentation per final PR comments

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 7566781 into hashicorp:main Sep 30, 2022
@modular-magician modular-magician deleted the downstream-pr-e6985aea75c311e6592c180e910a32e60a759af9 branch November 16, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant