Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds startup_probe field to google_cloud_run_service resource for beta #4773

Conversation

modular-magician
Copy link
Collaborator

Part of hashicorp/terraform-provider-google#12532.

Adds startup_probe field to google_cloud_run_service resource for google beta provider.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudrun: added field `startup_probe` to resource `google_cloud_run_service` (beta)

Derived from GoogleCloudPlatform/magic-modules#6532

… beta (hashicorp#6532)

* add startup probe

* add liveness probe

* startup only

* startup only

* feedback

* removed comment

* new line at the end

* default changes. beta.

* use underscore

* Update mmv1/products/cloudrun/terraform.yaml

Co-authored-by: Riley Karson <[email protected]>

* do not check annotation

* failed tests

* change tests

* add comment

* not empty

* Update mmv1/products/cloudrun/api.yaml

Co-authored-by: Sam Levenick <[email protected]>

* add exactly_one_of

* reorder

* full path

Co-authored-by: Riley Karson <[email protected]>
Co-authored-by: Sam Levenick <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit f96b7df into hashicorp:main Oct 10, 2022
@modular-magician modular-magician deleted the downstream-pr-c20670ad077706c430de76a4445dedd31332a3cf branch November 16, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant