Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete support and handwriten sweeper for Firebase Web App #4796

Conversation

modular-magician
Copy link
Collaborator

Support DELETE for Firebase Web apps. By default the delete is soft with a 30 days expiration. For the sweeper, there is no point keeping test apps for 30 days thus the hard-delete.

If this PR is for Terraform, I acknowledge that I have:

  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

firebase: added deletion support and new field `deletion_policy` for `google_firebase_web_app`

Derived from GoogleCloudPlatform/magic-modules#6652

@modular-magician modular-magician merged commit c5a8718 into hashicorp:main Oct 17, 2022
@modular-magician modular-magician deleted the downstream-pr-c285731bdb3177f5f5ea5fc680bf0185cfb45fcd branch November 16, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant