Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase hosting channel #4890

Conversation

modular-magician
Copy link
Collaborator

Add resource google_firebase_hosting_channel

If this PR is for Terraform, I acknowledge that I have:

  • I opened one and commented that I would like to work on it (not necessary for very small changes) Support Firebase Hosting terraform-provider-google#12955.
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_firebase_hosting_channel`

Derived from GoogleCloudPlatform/magic-modules#6791

* Firebase Hosting Channels

* Use references site_id

* Add handwritten update test

* Use billing_project instead of project

* Remove dependence on a project

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit c9a0868 into hashicorp:main Nov 16, 2022
@modular-magician modular-magician deleted the downstream-pr-5fa8435043f7f94d4f565291de79a79fbecf5e50 branch November 16, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant