Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Eventarc GoogleChannelConfig Resource support for TPG #4905

Conversation

modular-magician
Copy link
Collaborator

I have made changes to the magic-modules repo to support a new resource the Eventarc team has created, called GoogleChannelConfig. It is a regional singleton resource that enables customers to proctect their data with encryption for all first party triggers.

Fixes: hashicorp/terraform-provider-google#12520

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_eventarc_google_channel_config

Derived from GoogleCloudPlatform/magic-modules#6534

@modular-magician modular-magician merged commit 2ebf29b into hashicorp:main Nov 18, 2022
@modular-magician modular-magician deleted the downstream-pr-6b80c15e0e2512f0ec05d270c8be41e4c0050073 branch November 16, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add resource to TPG, Eventarc Google Channel Config
1 participant