Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add triggerer for CC to Beta #5055

Conversation

modular-magician
Copy link
Collaborator

Add Cloud Composer triggerer support to Beta.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

composer: added `triggerer` field in `google_composer_environment` (beta only)

Fixes hashicorp/terraform-provider-google/#13102

Derived from GoogleCloudPlatform/magic-modules#6967

* Add Triggerer for Cloud Composer to Beta

* Update composer triggerer documentation.

* Fix review comments

* Fix review comments.
Make Triggerer fields required
Update Composer2 test to include triggerer

* Remove atleastof as we have required=true for triggerer fields.

* retrigger checks

* Fix review comments:
1) Update triggerer values in the update test.
2) Cleanup documentation.

* [Composer Triggerer]
Fix formatting
Update docs

* retrigger checks

* retrigger checks

Co-authored-by: rlapin-pl <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 4ec1539 into hashicorp:main Jan 6, 2023
@modular-magician modular-magician deleted the downstream-pr-5d54b1e70ecb68763d41775aa2e521cc20ec76b4 branch November 16, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Terraform support for Cloud Composer's Airflow triggerer beta
1 participant