Datasource - google_sql_database_instances #5066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added validation for "type" in cloud_sql_user_resource for preventing user from setting "password" or "host" for CLOUD_IAM_USER and CLOUD_IAM_SERVICE_ACCOUNT user types. * Added new data_source_sql_database_instance_list data source and test file * Added new data_source_sql_database_instance_list data source and test file * Reverting validation of usert types, this would be added as a seperate PR * Added documentation for the new google_sql_database_instances data source * mend * mend * mend * mend * mend Signed-off-by: Modular Magician <[email protected]>
modular-magician
deleted the
downstream-pr-3f9409b5df7be27b02f4481c4ebf6a9879739f03
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to create a new data source as request in the issue mentioned in hashicorp/terraform-provider-google#8164
Buganizer reference : (b/259913353): EXT: Datasource google_sql_database_instances
I have created a new data source called "google_sql_database_instance_list" which would fetch all the database instances in a project, and u can apply filters on top of it {project, database_version, region, zone, tier and state}.
I have tested this new data source with unit tests.
Derived from GoogleCloudPlatform/magic-modules#6980