Adding support for point_in_time_recovery_enabled flag in mssql instances
#5079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tances (hashicorp#7096) * Added validation for "type" in cloud_sql_user_resource for preventing user from setting "password" or "host" for CLOUD_IAM_USER and CLOUD_IAM_SERVICE_ACCOUNT user types. * Removed validation and added documentation to prevent setting of host or password field for CLOUD_IAM_USER and CLOUD_IAM_SERVICE_ACCOUNT * Updated the validation function to allow the setting of flag for mssql instance, since the API supports it now. Updated documntation as well. * Updated the validation function to allow the setting of flag for mssql instance, since the API supports it now. Updated documntation as well. * Added test function for checking support for point_in_time_recovery_enabled flag in Sql Server. Signed-off-by: Modular Magician <[email protected]>
modular-magician
deleted the
downstream-pr-cd439332f58002e316ac239cafb626edc507a8b7
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix hashicorp/terraform-provider-google#13151
Bugaizer ticket : b/261459520
Updated the validation function to allow the setting of
point_in_time_recovery_enabledflag for mssql instance, since the API supports it now. Updated the documentation as well.If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Derived from GoogleCloudPlatform/magic-modules#7096