Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max_run_duration to instance and instance template on Beta #5096

Conversation

modular-magician
Copy link
Collaborator

Add max_run_duration support that will set a deadline for running VM (Beta).

See MaxRunDuration section in
https://pkg.go.dev/google.golang.org/[email protected]/compute/v0.beta

part of hashicorp/terraform-provider-google#13005

Testing disclaimer: I verified the VM is created successfully, and the parameter is correct, however, the test is failed, I think it is more like the environment/framework issue, and I can not figure out how to fix.
provider_test.go:307: Failed state verification, resource with ID projects/debian-cloud/global/images/debian-11-bullseye-v20221102 not found

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added `max_run_duration` field to `google_compute_instance` and `google_compute_instance_template` resource (beta)

Derived from GoogleCloudPlatform/magic-modules#6812

@modular-magician modular-magician merged commit 6a1685c into hashicorp:main Jan 13, 2023
@modular-magician modular-magician deleted the downstream-pr-1bca5c3c8d1874eb95d6ed2a7a53cbef83b32f58 branch November 16, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant