Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for edge_security_policy to google_compute_backend_service #5101

Conversation

modular-magician
Copy link
Collaborator

Fixes hashicorp/terraform-provider-google#12867

Adds edge_security_policy field to the backend service resource in the compute api.yaml and terraform.yaml files, adds support for the post_create update command in compute_backend_service_security_policy.go.erb, and updates the corresponding handwritten test.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: add support for 'edge_security_policy' field to 'google_compute_backend_service' resource.

Derived from GoogleCloudPlatform/magic-modules#7120

hashicorp#7120)

* updated backend service for edge security policy

* Updated fields for diff suppression, modified post_create custom go code and updated security policy tests.

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 25fe035 into hashicorp:main Jan 13, 2023
@modular-magician modular-magician deleted the downstream-pr-38fc58660118de280702495f861776ac330215b1 branch November 16, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for edge-security-policy param in google_compute_backend_service
1 participant