Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share settings for sole-tenant node groups. #5113

Conversation

modular-magician
Copy link
Collaborator

This PR introduces support for cross-project sharing of Node Groups.
This PR resolves Issue 13281.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Note on acceptance tests
I ran the acceptance tests locally with my own projects instead of automatically created projects due to some limitations in my organisation.

Release Note Template for Downstream PRs (will be copied)

compute: added `share_settings` field to the `google_compute_node_group` resource.

Derived from GoogleCloudPlatform/magic-modules#7059

* Share settings for sole-tenant node groups.

* Fixes after review.

Co-authored-by: Igor Dyczko <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 9041d0e into hashicorp:main Jan 18, 2023
@modular-magician modular-magician deleted the downstream-pr-ea442ae1c381f53dbf8012697e7110ba7c14ee73 branch November 16, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform support for cross-project Sole Tenancy.
1 participant