Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Auto deploy config to google_compute_security_policy to support Cloud Armor #5116

Conversation

modular-magician
Copy link
Collaborator

API: https://cloud.google.com/compute/docs/reference/rest/beta/securityPolicies

https://cloud.google.com/armor/docs/adaptive-protection-auto-deploy

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: Added fields to resource `google_compute_security_policy` to support Cloud Armor Auto Deploy (beta)

Derived from GoogleCloudPlatform/magic-modules#7029

… Cloud Armor (hashicorp#7029)

* feat: add autodeploy config on security policy

* fix: removeunless version

* fix: remove println on test

* fix: add maxitem on autodeploy rules

* fix: fix spaces, documentation and unnecessary code

* fix: adjust spaces

* fix: fix spaces and positions

* fix: correct layer_7_ddos_defense_config test

* fix: go back with forcesendfields

* fix: remove ForceSendFields

* test: add update step on autoDeployConfig test

* fix: adjust indent

* fix: put beta information on markdown

* fix: fix indentation

* "fix: adjust value test and adjust markdown"

Co-authored-by: afpesseti <[email protected]>
Co-authored-by: Ana Flávia <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit cb97e0f into hashicorp:main Jan 19, 2023
@modular-magician modular-magician deleted the downstream-pr-dda1112c2a832c63eb2043c1c6bba6f23c9763c6 branch November 16, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant