Cloud Workstations - Workstation Config #5246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add WorkstationConfig resource * indent correctly * add the workstationConfig * Add WorkstationConfig * Create workstation_config_basic.tf.erb * Create resource_workstations_workstation_config_test.go.erb * fix indent * remove duplicate displayName field * add `workstationClusterId` param * set host attribute block * set the `workstation_cluster_id` * fix create * use a default for the container property * add input true * set api defaults * set `host.gceInstance.bootDiskSizeGb` to be computed * fix machine_type attribute * fix typo's * lower case funcs * Update mmv1/third_party/terraform/tests/resource_workstations_workstation_config_test.go.erb Co-authored-by: Riley Karson <[email protected]> * add location * add skip test to examples * add tests to run sequentially instead of paralell * set `<% unless version == 'ga' -%>` * Remove extra tests * align google_workstations_workstation_config resource in update test * Revert "align google_workstations_workstation_config resource in update test" This reverts commit 37a4af300e0d78b4110c8029f09511ae1957e6c9. * Revert "Remove extra tests" This reverts commit 1fc074464b3fea0293884bbda86725a81e2f08e6. * revert skip test * align tests and remove update label * add encryptionKey attribute * indent the description * add encryption key test * Use a static `account_id` for KMS SA * address comments on pr * set some extra defaults * add 2 new tests to test host and persistent_directories * Move back up * have a single set of unless/end * remove data google project * Remove faulty import * remove duplicate output and fmt * remove output field on displayName * add displayName update test * Fix update of display name --------- Co-authored-by: Riley Karson <[email protected]> Signed-off-by: Modular Magician <[email protected]>
modular-magician
deleted the
downstream-pr-91d96c897eb8537ba19f66c1652083d14aa32aa6
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The leading pull request for this is: GoogleCloudPlatform/magic-modules#7005, that should be merged first. (as I've split up the PRs for this new service)
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#7017