Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WEIGHTED_MAGLEV to localityLbPolicy enum, and update associated docstrings. #5353

Conversation

modular-magician
Copy link
Collaborator

This PR adds WEIGHTED_MAGLEV to the enum for localist_lb_policy, resolving b/272540261 and unblocking NetLB Weighted Load Balancing GA.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.
compute: added `WEIGHED_MAGLEV` to `locality_lb_policy` enum for backend service resources.

Derived from GoogleCloudPlatform/magic-modules#7444

…ocstrings. (hashicorp#7444)

* Add WEIGHTED_MAGLEV to localityLbPolicy enum, and update associated docstrings.

* Example for WEIGHTED_MAGLEV uses HTTP health check.

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 8050cf5 into hashicorp:main Mar 21, 2023
@modular-magician modular-magician deleted the downstream-pr-3b51df97a49abfbf52f477e3a8ce2ff4a7e2a0d5 branch November 16, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant