Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

id of instance templates now relies on the unique id of the resource #5384

Conversation

modular-magician
Copy link
Collaborator

This is a security improvement to prevent instance templates being replaced after an instance template is created and before it is used by another resource (e.g. MIG creation). It introduces the self_link_unique computed attribute for google_compute_instance_template's that can be used to prevent TOCTOU attacks when resources are created in an untrusted environment.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added output-only attribute `self_link_unique` id for `google_compute_instance_template` to point to the unique id of the resource (instead of its name). It is recommended to use `self_link_unique` for references over `self_link` and `id` for `google_compute_instance_template`

Derived from GoogleCloudPlatform/magic-modules#7358

@modular-magician modular-magician merged commit 3b81306 into hashicorp:main Mar 28, 2023
@modular-magician modular-magician deleted the downstream-pr-7f28bb64b5fa2c85f2f6e723b2cc59d4b6f07e8b branch November 16, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant