Fix SQL instance sweeper to only delete sweepable instances #5418
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sweeper was mistakenly deleting all SQL instances, instead of only deleting instances whose name matched
IsSweepableTestResource()
. In practice, this meant that our bootstrapped instance was being deleted on every run in GA.Besides reducing churn and test run time, this change greatly reduces the chance of test failures that occur when relying on the bootstrapped instance immediately after it is created. Specifically, it appears that some of our tests will mistakenly try to clone the bootstrapped instance based off of a backup that is automatically created before the instance is actually done being created, and then they fail. This should not occur after the bootstrapped instance has had time to create other backups.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#7602