Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQL instance sweeper to only delete sweepable instances #5418

Conversation

modular-magician
Copy link
Collaborator

This sweeper was mistakenly deleting all SQL instances, instead of only deleting instances whose name matched IsSweepableTestResource(). In practice, this meant that our bootstrapped instance was being deleted on every run in GA.

Besides reducing churn and test run time, this change greatly reduces the chance of test failures that occur when relying on the bootstrapped instance immediately after it is created. Specifically, it appears that some of our tests will mistakenly try to clone the bootstrapped instance based off of a backup that is automatically created before the instance is actually done being created, and then they fail. This should not occur after the bootstrapped instance has had time to create other backups.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#7602

@modular-magician modular-magician merged commit be9d2f6 into hashicorp:main Apr 3, 2023
@modular-magician modular-magician deleted the downstream-pr-c8b7342e2af36fe03130db2975d23951efaa197d branch November 16, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant