Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: google_cloud_identity_group initialGroupConfig #5456

Conversation

modular-magician
Copy link
Collaborator

According to 1 initialGroupConfig is an immutable parameter in both v1 and v1beta of the Cloud Identity groups API, and the updateMask for groups.patch does not accept it (it's a URL parameter in groups.create). Aside from the current implementation not correctly destroying and re-creating the resource when initial_group_config changes, requests in which no updateMask fields change results in a URL containing updateMask= which causes the API to error:

PATCH /v1/{name=groups/*}&updateMask=

{
"error": {
    "code": 400,
    "message": "Request contains an invalid argument.",
    "status": "INVALID_ARGUMENT"
}

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudidentity: fixed immutability issue on `initialGroupConfig` field for resource `google_cloud_identity_group`

Derived from GoogleCloudPlatform/magic-modules#7622

@modular-magician modular-magician merged commit 76ab031 into hashicorp:main Apr 10, 2023
@modular-magician modular-magician deleted the downstream-pr-c095489b7b53e1dfa0c4f545d0ef3616c506e7e8 branch November 16, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant