Fix empty string credentials validation issue, increase test coverage of credential validation #5466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hashicorp/terraform-provider-google#14255
This PR:
credentials
in the provider configHere are details of old tests that I replaced with test cases in a table-driven test
TestProvider_loadCredentialsFromFile
(SDK version)TestProvider_validateCredentials
's "configuring credentials as a path to a credentials JSON file is valid"TestProvider_loadCredentialsFromJSON
(SDK version)TestProvider_validateCredentials
's "configuring credentials as a credentials JSON string is valid"TestFrameworkProvider_loadCredentialsFromFile
TestFrameworkProvider_CredentialsValidator
's "configuring credentials as a path to a credentials JSON file is valid"TestFrameworkProvider_loadCredentialsFromJSON
TestFrameworkProvider_CredentialsValidator
's "configuring credentials as a credentials JSON string is valid"If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#7690