Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for CMEK in alloydb backup resource #5549

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Added support for CMEK in alloydb backup resource #5549

merged 1 commit into from
Apr 25, 2023

Conversation

modular-magician
Copy link
Collaborator

Added support for CMEK in alloydb backup resource.

This is one of the 2 PR is to fix hashicorp/terraform-provider-google#13250

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.
alloydb: added support for CMEK in `google_alloydb_backup` resource

Derived from GoogleCloudPlatform/magic-modules#7829

@modular-magician
Added support for CMEK in alloydb backup resource (hashicorp#7829)
cdca462 
* Added validation for "type" in cloud_sql_user_resource for preventing user from setting "password" or "host" for CLOUD_IAM_USER and CLOUD_IAM_SERVICE_ACCOUNT user types.

* Removed validation and added documentation to prevent setting of host or password field for CLOUD_IAM_USER and CLOUD_IAM_SERVICE_ACCOUNT

* Added support for CMEK in alloydb backup resource

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 0df1438 into hashicorp:main Apr 25, 2023
@modular-magician modular-magician deleted the downstream-pr-301e77ec2ef7dd038e2a0223dcd9431787754123 branch November 16, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CMEK option for alloyDB
1 participant
@modular-magician