Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cloud Workstations resources in the beta provider. #5585

Conversation

modular-magician
Copy link
Collaborator

This change adds support for timeout-related fields to the Cloud Workstations config resource, and also updates several others so they can be updated via PATCH to avoid re-creating the underlying resource.

This provides fixes for the following issues:


This PR is for Terraform. I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

workstations: supported in-place update for `host` and `container` in `google_workstations_workstation_config` (beta)
workstations: fixed an issue where unsetting the container working directory in `google_workstations_workstations_config` was not propagated to the underlying resource (beta)
workstations: fixed an issue where modifying `persistent_directories` and `encryption_key` would fail with API errors; now updating them will recreate the resource (beta)

Derived from GoogleCloudPlatform/magic-modules#7629

…7629)

* Update mutability of fields in Cloud Workstations resources.

* Revert WorkstationsConfig persistent directories fields to be default_from_api.

* Revert and mark breaking changes for Cloud Workstations resources.

* Update display name for Cloud Workstation.

* Revert default_from_api on fields not sent by API if not changed.

* Add an update test for Cloud Workstations host field.

* Add more update tests to include all recently changed fields.

* Revert addition of idle and running timeout fields.

* Fix config tests for newly mutable attributes.

* Use default value instead of sending empty for advanced host options.

* Send empty values for special nested objects, configure diff suppress when empty.

* Add custom flatteners for instance configs.

* Add default_from_ap to ssubfields where custom flatteners are used.

* Send default_from_api on entire config block instead of fields.

* Fix formatting for attributes not caught by rebase.

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 2d8e277 into hashicorp:main May 3, 2023
@modular-magician modular-magician deleted the downstream-pr-4909426ed99781e7806040f4a0eb31f15cdc9959 branch November 16, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant