Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Empty Dir Volumes and the Container Dependencies to Cloud Run v2 #5613

Conversation

modular-magician
Copy link
Collaborator

Adds support for the Empty Dir volume type in Cloud Run v2 Services and Jobs as well as Service container dependencies using the depends_on container field.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudrunv2: Added the beta field `template.containers.depends_on` to `google_cloud_run_v2_service`.
cloudrunv2: Added the beta field `template.volumes.empty_dir` to `google_cloud_run_v2_service`.
cloudrunv2: Added the beta field `template.template.volumes.empty_dir` to `google_cloud_run_v2_job`.

Derived from GoogleCloudPlatform/magic-modules#7897

…loud Run v2 (hashicorp#7897)

* Add support for the depends_on field in the Cloud Run v2 API.

* Add emptyDir volume type for the Cloud Run v2 API

* Add Cloud Run v2 Service multi-container example

* Add Cloud Run v2 Job empty dir volume example

* Add default value for empty dir medium in Cloud Run volumes

* Mark empty_dir and depends_on as beta fields

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit a2e39fd into hashicorp:main May 9, 2023
@modular-magician modular-magician deleted the downstream-pr-015daec7ba39f3829f7efe24f81bded59695f5e5 branch November 16, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant