Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Dataplex Datascan as a resource #5707

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Adding Dataplex Datascan as a resource #5707

merged 1 commit into from
Jun 1, 2023

Conversation

modular-magician
Copy link
Collaborator

Adding a new Dataplex resource: Datascan.

Related PR with code review comments: GoogleCloudPlatform/magic-modules#7911

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_dataplex_datascan_*`

Derived from GoogleCloudPlatform/magic-modules#8010

@modular-magician
Adding Dataplex Datascan as a resource (hashicorp#8010)
f3ff61a 
* Add resource and simple example file

* Add dataScanId and updated example

* Terraform create resource works! Need to handle async

* Tests passing!

* Added examples; broken tests

* Updated examples

* Update examples with additional fields coverage

* Change BQ dataset in example, and add default_from_api

* Acceptance tests passing locally

* Fixes to IAM tests

* minor formatting in examples

* Trigger github tests

* Trigger github tests after increasing SetIAM quota

* Update import path

* Remove IAM policy config

* Add additional required property to Datascan fields

* Update yaml and fix formatting in examples

* Fix formatting issues for dimension in YAML

* fix exactly_one_of

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit a82b9d9 into hashicorp:main Jun 1, 2023
@modular-magician modular-magician deleted the downstream-pr-3f281b8624e8ff0956ba0edffcd1234497838e9a branch November 16, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@modular-magician