Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeouts support for BigTable operations #5752

Conversation

modular-magician
Copy link
Collaborator

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

bigtable: add timeout support for bigtable admin operations 

Fixes hashicorp/terraform-provider-google#13045

Derived from GoogleCloudPlatform/magic-modules#8037

* Update resource_bigtable_gc_policy.go

* Update resource_bigtable_instance.go

* Update resource_bigtable_table.go

* Improve timeout handling

* Improve timeout handling

* Adjust default timeout value

* Adjust default timeout value

* Add example

* Fixed according to review

* Fixed according to review

* remove unneeded example

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 99ce57e into hashicorp:main Jun 8, 2023
@modular-magician modular-magician deleted the downstream-pr-887b7798751d630e771d3b0eff751c2c892c2365 branch November 16, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support configurable timeouts for Bigtable resources
1 participant