Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make service account name in bq transfer config mutable #5777

Conversation

modular-magician
Copy link
Collaborator

Changing service account name of a bigquery transfer config forces replacement of the transfer config, which is unnecessary. This change makes the service account name mutable and adds a handwritten test for service account name change.

fixes issue #14123

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: made service account name mutable in bigquerydatatransfer config

Derived from GoogleCloudPlatform/magic-modules#8152

@modular-magician modular-magician merged commit dc4b29f into hashicorp:main Jun 15, 2023
@modular-magician modular-magician deleted the downstream-pr-784270b61c908721bf34424b8ba7a05d203a3e86 branch November 16, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant